Page MenuHomePhorge
Files F2503963

D25602.1726851184.diff
No OneTemporary
Actions

D25602.1726851184.diff
View Options

diff --git a/src/applications/maniphest/controller/ManiphestReportController.php b/src/applications/maniphest/controller/ManiphestReportController.php
--- a/src/applications/maniphest/controller/ManiphestReportController.php
+++ b/src/applications/maniphest/controller/ManiphestReportController.php
@@ -487,6 +487,12 @@
);
}
+ private function getAveragePriority() {
+ // TODO: This is sort of a hard-code for the default "normal" status.
+ // When reports are more powerful, this should be made more general.
+ return 50;
+ }
+
public function renderOpenTasks() {
$request = $this->getRequest();
$viewer = $request->getUser();
@@ -626,9 +632,7 @@
$normal_or_better = array();
foreach ($taskv as $id => $task) {
- // TODO: This is sort of a hard-code for the default "normal" status.
- // When reports are more powerful, this should be made more general.
- if ($task->getPriority() < 50) {
+ if ($task->getPriority() < $this->getAveragePriority()) {
continue;
}
$normal_or_better[$id] = $task;
@@ -700,13 +704,22 @@
),
pht('Oldest (All)'));
$cclass[] = 'n';
+ $low_priorities = array();
+ $priorities_map = ManiphestTaskPriority::getTaskPriorityMap();
+ $normal_priority = $this->getAveragePriority();
+ foreach ($priorities_map as $pri => $full_label) {
+ if ($pri < $normal_priority) {
+ $low_priorities[] = $full_label;
+ }
+ }
+ $pri_string = implode(', ', $low_priorities);
$cname[] = javelin_tag(
'span',
array(
'sigil' => 'has-tooltip',
'meta' => array(
'tip' => pht(
- 'Oldest open task, excluding those with Low or Wishlist priority.'),
+ 'Oldest open task, excluding those with priority %s', $pri_string),
'size' => 200,
),
),

File Metadata

Mime Type
text/plain
Expires
Fri, Sep 20, 16:53 (18 h, 34 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
893294
Default Alt Text
D25602.1726851184.diff (1 KB)

Event Timeline

Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0