Paths

Table of Contentst

Differential D25635

Fix PHP 8.1 "preg_replace(null)" exception in PhabricatorEditorURIEngine.php
Needs ReviewPublic
Actions

Authored by aklapper on Sat, May 11, 20:51.

Details

Reviewers

None

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15824: Deprecation notice at PhabricatorEditorURIEngine.php:283

Summary

Passing null to preg_replace() is deprecated behavior since PHP 8.1.
Thus only call preg_replace() when $token is non-empty.

ERROR 8192: preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated at [<phorge>/src/infrastructure/editor/PhabricatorEditorURIEngine.php:283]

Closes T15824

Test Plan

Unclear.

Diff Detail

Repository

rP Phorge

Branch

T15824pregReplace (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1251
Build 1251: arc lint + arc unit

Event Timeline

aklapper created this revision.Sat, May 11, 20:51

Owners added a reviewer: O1: Blessed Committers.Sat, May 11, 20:51

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptSat, May 11, 20:51

aklapper requested review of this revision.Sat, May 11, 20:51

Harbormaster completed remote builds in B1251: Diff 1976.Sat, May 11, 20:51

How can we end up with null here?

Uhm, seems I was somehow off by one line. I thought that this comes from escapeToken($repository->getCallsign()) being optional nowadays but seems to be triggered by escapeToken($repository->getRepositorySlug()) instead which indeed would be surprising. This might be a patch to abandon because might hide an underlying issue.

Revision Contents
Changeset List

Path

Size

Packages

src/

infrastructure/

editor/

PhabricatorEditorURIEngine.php

9 lines

O1: Blessed Committers

Diff 1976

View Options

src/infrastructure/editor/PhabricatorEditorURIEngine.php

Fix PHP 8.1 "preg_replace(null)" exception in PhabricatorEditorURIEngine.phpNeeds ReviewPublicActions