Paths

Table of Contentst

Differential D25629

Fix PHP 8.1 "strlen(null)" exception rendering Conpherence search results
ClosedPublic
Actions

Authored by aklapper on Thu, May 9, 11:24.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, May 30, 22:17

	Unknown Object (File)
	Wed, May 22, 21:18

	Unknown Object (File)
	Tue, May 21, 00:57

	Unknown Object (File)
	Mon, May 20, 22:47

	Unknown Object (File)
	Mon, May 20, 00:54

	Unknown Object (File)
	Sun, May 19, 23:33

	Unknown Object (File)
	Sun, May 19, 14:27

	Unknown Object (File)
	Sun, May 19, 02:11

View All 24 Files

Subscribers

valerio.bozzolan

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15818: PHP 8.1 "strlen(null)" exception rendering Conpherence search results

Commits

rP61c953268ecd: Fix PHP 8.1 "strlen(null)" exception rendering Conpherence search results

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/conpherence/query/ConpherenceThreadSearchEngine.php:154]

See also similar rPe65ac7b8800d3397abfced7824a8d316ec573d8f

Closes T15818

Test Plan

Go to http://phorge.localhost/conpherence/search/query/all/

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Thu, May 9, 11:24

Owners added a reviewer: O1: Blessed Committers.Thu, May 9, 11:24

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptThu, May 9, 11:24

aklapper requested review of this revision.Thu, May 9, 11:24

Harbormaster completed remote builds in B1239: Diff 1957.Thu, May 9, 11:24

It worked in line 109, it will work in line 154. Tested.

lgtm

This revision is now accepted and ready to land.Thu, May 9, 12:24

Closed by commit rP61c953268ecd: Fix PHP 8.1 "strlen(null)" exception rendering Conpherence search results. · Explain WhyThu, May 9, 12:42

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP61c953268ecd: Fix PHP 8.1 "strlen(null)" exception rendering Conpherence search results.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

conpherence/

query/

ConpherenceThreadSearchEngine.php

2 lines

O1: Blessed Committers

Diff 1961

src/applications/conpherence/query/ConpherenceThreadSearchEngine.php

Loading...