Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception in PhabricatorStandardCustomFieldLink.php
ClosedPublic

Authored by aklapper on Wed, May 1, 15:40.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 10, 12:28
Unknown Object (File)
Fri, May 10, 10:20
Unknown Object (File)
Thu, May 9, 22:50
Unknown Object (File)
Tue, May 7, 10:29
Unknown Object (File)
Sun, May 5, 23:32
Unknown Object (File)
Sun, May 5, 23:32
Unknown Object (File)
Sun, May 5, 01:59
Unknown Object (File)
Sat, May 4, 15:58

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15807

Test Plan

Unknown. Given that $value is later used to construct a phutil_tag I assume that it should be a string and not a scalar.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable