For some reasons I see that most of the links open in an external tab, as default.
Steps to reproduce:
* Visit these links:
| Link | What happens |
|------|--------------|
| https://example.com/ | new tab |
| https://we.phorge.it/project/view/64/ | new tab |
| [[ /project/view/64/ | /project/view/64/ ]] | new tab |
| [[ / ]] | same tab |
Expected behavior:
* Not all absolute links should open in a new tab - for example, links starting with "https://we.phorge.it/" are probably better to be opened in the same tab
* Relative links are also probably better to be opened in the same tab
Also, see the Home of Phorge itself:
> {W5}
You see that most of the links open in a new tab as default. Why?
Having indiscriminate external links is not a best practice in the web. See this Task that has a more deep thought about this topic:
* {T15172}
With that in mind, since I don't want to change things too much, I would start by changing the default, not for all the links, but only for links pointing to an internal destination:
* {D25084}
This is a compromise, because there was probably a good reason for opening links in an external tab and it doesn't seem fair to me to just undo this for all the links.
This then still allows in the future to see how it goes, and, if you want, to possibly just put all the links as default to open in the same tab, unless there are strong usability issues already mentioned in T15172.
Truth table of the proposal (assuming that your local URL is https://we.phorge.it/):
| | https://duckduckgo.com | [[ changelog/ ]] | [[ #anchor | #anchor ]] | https://we.phorge.it/ | [[ /config/ | /config/ ]] |
| Before this change | external | internal | internal | external | external |
| After this change | external | internal | internal | **internal** | **internal** |
== Test on your local Phorge ==
This is just an example Remarkup that you can use to test the situation locally:
```
== Links that should NOT open in an external tab as default ==
http://phorge.localhost/phriction/edit/3/
<http://phorge.localhost/#asd>
<http://phorge.localhost/phriction/edit/3/>
[[ http://phorge.localhost/phriction/edit/3/ | http://phorge.localhost/phriction/edit/3/ ]]
[[ /phriction/edit/3/ | /phriction/edit/3/ ]]
== Still internal links as default ==
[[ / ]]
[[ #asd | #asd ]]
== Still External Links as default ==
https://google.com/
<https://google.com/>
[[ https://google.com/| https://google.com/ ]]
```