Change Details

For objects that support "Flags" and `PhabricatorApplicationSearchController`, allow searching by flag color. This should be easy(?) to implement by adding implementation of `PhabricatorSearchEngineExtension`.

"Flags" appears to predate much of the current architecture. Current implementation is as stand-alone objects that refer to other objects by phid. The downside of current approach is that fetching the information requires a separate DB call (We don't allow cross-application table joins). Reimplementing as Edges would allow integration with modern interfaces, including: - Filtering objects in all search engines based on having flags - Showing flags in search results and hovercards. Caveats: - Updating flags should not leave a trace in the target object - flags are private to the owner. So no transaction record.

For objects that support "Flags" and `PhabricatorApplicationSearchController`, allow seppears to predate much of the current arching by flag colortecture. This should be easy(?) to implement by adding implementation of `PhabricatorSearchEngineExtension`.Current implementation is as stand-alone objects that refer to other objects by phid. The downside of current approach is that fetching the information requires a separate DB call (We don't allow cross-application table joins). Reimplementing as Edges would allow integration with modern interfaces, including: - Filtering objects in all search engines based on having flags - Showing flags in search results and hovercards. Caveats: - Updating flags should not leave a trace in the target object - flags are private to the owner. So no transaction record.