Interestingly some cases the {nav Move} action on a Tabs Panels works, but the graphical interface shows that action as disabled.
Steps to reproduce:
- From user A:
- Create two panels - __editable by: User A__
- From user B:
- Create a "Tabs Panel" in a Dashboard
- Attach the panels __from User A__ (so, editable by, not you)
Then, the second Panel in a Tabsfrom User B, seems not movable:see the {nav Move} actions that are grayed out:
{F313580,size=full}
But it can :) If I click onthe {nav Move to Left}, it} actions actually works! Even if it's grayed out :) and that is OK.
----
I can reproduce this problem on this Dashboard where I attached some panels that are not mine, and the Move actions are disabled, but they work as expected:
https://phab.wmflabs.org/dashboard/view/12/
NOTE: the Dashboard is mine, the first panel is mine, __the other panel is not mine and not editable by me__. Maybe that is the problem.
----
ProbablyIn short, the panelTabs should be movable on the Dashboarde only if you can:
- Edit the Dashboardparent Tabs Panel
But at the moment, these actions are grayed out if you cannot:disabled from the frontend also if you cannot edit the Sub-Panel themselves. But this is misleading, since you are //not// touching the Sub-Panel(s) at all, you are just showing many of them in a different order decided by you, that you created a parent Tabs Panel.
- EditSo the Dashboard
- Edit the Panel itselferror is probably here:
```
name=PhabricatorDashboardTabsPanelType.php,lang=php
$dropdown_menu->addAction(
id(new PhabricatorActionView())
->setName(pht('Move Tab Left'))
->setIcon('fa-chevron-left')
->setHref($prev_uri)
->setWorkflow(true)
->setDisabled(($prev_key === null) || !$can_edit));
$dropdown_menu->addAction(
id(new PhabricatorActionView())
->setName(pht('Move Tab Right'))
->setIcon('fa-chevron-right')
->setHref($next_uri)
->setWorkflow(true)
->setDisabled(($next_key === null) || !$can_edit));
```
So maybe the issue is just about thatremoving the `|| !$can_edit`, since that is an additional check not really intended, and also not consistent with the backend.
In short:
If you can Edit the Tabs Panel, thatof course you should also be removedable to Move things in it.