Change Details

Phorge at 5444e1c885c337ede0f1fb4ad1916ae0b49b1413, PHP 8.3.6. Following the steps in T15790 and trying to manage/edit the panel again which throws an exception, I get: ```[2024-04-18 17:35:03] ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/dashboard/editfield/PhabricatorDashboardQueryPanelQueryEditField.php:41] arcanist(head=master, ref.master=ef73b12b580e), phorge(head=master, ref.master=5444e1c885c3) #0 PhabricatorDashboardQueryPanelQueryEditField::newControl() called at [<phorge>/src/applications/transactions/editfield/PhabricatorEditField.php:352] #1 PhabricatorEditField::buildControl() called at [<phorge>/src/applications/transactions/editfield/PhabricatorEditField.php:385] #2 PhabricatorEditField::renderControl() called at [<phorge>/src/applications/transactions/editfield/PhabricatorEditField.php:415] #3 PhabricatorEditField::appendToForm(AphrontFormView) called at [<phorge>/src/applications/transactions/editengine/PhabricatorEditEngine.php:1386] #4 PhabricatorEditEngine::buildEditForm(PhabricatorDashboardPanel, array) called at [<phorge>/src/applications/transactions/editengine/PhabricatorEditEngine.php:1242] #5 PhabricatorEditEngine::buildEditResponse(PhabricatorDashboardPanel) called at [<phorge>/src/applications/transactions/editengine/PhabricatorEditEngine.php:1000] #6 PhabricatorEditEngine::buildResponse() called at [<phorge>/src/applications/dashboard/controller/panel/PhabricatorDashboardPanelEditController.php:66] #7 PhabricatorDashboardPanelEditController::handleRequest(AphrontRequest) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:284] #8 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:203] #9 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phorge>/webroot/index.php:35] [2024-04-18 17:35:03] ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/dashboard/editfield/PhabricatorDashboardQueryPanelQueryEditField.php:59] arcanist(head=master, ref.master=ef73b12b580e), phorge(head=master, ref.master=5444e1c885c3) #0 PhabricatorDashboardQueryPanelQueryEditField::newControl() called at [<phorge>/src/applications/transactions/editfield/PhabricatorEditField.php:352] #1 PhabricatorEditField::buildControl() called at [<phorge>/src/applications/transactions/editfield/PhabricatorEditField.php:385] #2 PhabricatorEditField::renderControl() called at [<phorge>/src/applications/transactions/editfield/PhabricatorEditField.php:415] #3 PhabricatorEditField::appendToForm(AphrontFormView) called at [<phorge>/src/applications/transactions/editengine/PhabricatorEditEngine.php:1386] #4 PhabricatorEditEngine::buildEditForm(PhabricatorDashboardPanel, array) called at [<phorge>/src/applications/transactions/editengine/PhabricatorEditEngine.php:1242] #5 PhabricatorEditEngine::buildEditResponse(PhabricatorDashboardPanel) called at [<phorge>/src/applications/transactions/editengine/PhabricatorEditEngine.php:1000] #6 PhabricatorEditEngine::buildResponse() called at [<phorge>/src/applications/dashboard/controller/panel/PhabricatorDashboardPanelEditController.php:66] #7 PhabricatorDashboardPanelEditController::handleRequest(AphrontRequest) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:284] #8 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:203] #9 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phorge>/webroot/index.php:35] ```

Phorge at 5444e1c885c337ede0f1fb4ad1916ae0b49b1413, PHP 8.3.6. Following the steps in T15790 and selecting "Manage Panel > Edit Panel" on the panel which threw an exception at creation, I get: ```[2024-04-18 17:35:03] ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/dashboard/editfield/PhabricatorDashboardQueryPanelQueryEditField.php:41] arcanist(head=master, ref.master=ef73b12b580e), phorge(head=master, ref.master=5444e1c885c3) #0 PhabricatorDashboardQueryPanelQueryEditField::newControl() called at [<phorge>/src/applications/transactions/editfield/PhabricatorEditField.php:352] #1 PhabricatorEditField::buildControl() called at [<phorge>/src/applications/transactions/editfield/PhabricatorEditField.php:385] #2 PhabricatorEditField::renderControl() called at [<phorge>/src/applications/transactions/editfield/PhabricatorEditField.php:415] #3 PhabricatorEditField::appendToForm(AphrontFormView) called at [<phorge>/src/applications/transactions/editengine/PhabricatorEditEngine.php:1386] #4 PhabricatorEditEngine::buildEditForm(PhabricatorDashboardPanel, array) called at [<phorge>/src/applications/transactions/editengine/PhabricatorEditEngine.php:1242] #5 PhabricatorEditEngine::buildEditResponse(PhabricatorDashboardPanel) called at [<phorge>/src/applications/transactions/editengine/PhabricatorEditEngine.php:1000] #6 PhabricatorEditEngine::buildResponse() called at [<phorge>/src/applications/dashboard/controller/panel/PhabricatorDashboardPanelEditController.php:66] #7 PhabricatorDashboardPanelEditController::handleRequest(AphrontRequest) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:284] #8 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:203] #9 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phorge>/webroot/index.php:35] [2024-04-18 17:35:03] ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/dashboard/editfield/PhabricatorDashboardQueryPanelQueryEditField.php:59] arcanist(head=master, ref.master=ef73b12b580e), phorge(head=master, ref.master=5444e1c885c3) #0 PhabricatorDashboardQueryPanelQueryEditField::newControl() called at [<phorge>/src/applications/transactions/editfield/PhabricatorEditField.php:352] #1 PhabricatorEditField::buildControl() called at [<phorge>/src/applications/transactions/editfield/PhabricatorEditField.php:385] #2 PhabricatorEditField::renderControl() called at [<phorge>/src/applications/transactions/editfield/PhabricatorEditField.php:415] #3 PhabricatorEditField::appendToForm(AphrontFormView) called at [<phorge>/src/applications/transactions/editengine/PhabricatorEditEngine.php:1386] #4 PhabricatorEditEngine::buildEditForm(PhabricatorDashboardPanel, array) called at [<phorge>/src/applications/transactions/editengine/PhabricatorEditEngine.php:1242] #5 PhabricatorEditEngine::buildEditResponse(PhabricatorDashboardPanel) called at [<phorge>/src/applications/transactions/editengine/PhabricatorEditEngine.php:1000] #6 PhabricatorEditEngine::buildResponse() called at [<phorge>/src/applications/dashboard/controller/panel/PhabricatorDashboardPanelEditController.php:66] #7 PhabricatorDashboardPanelEditController::handleRequest(AphrontRequest) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:284] #8 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:203] #9 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phorge>/webroot/index.php:35] ```

Phorge at 5444e1c885c337ede0f1fb4ad1916ae0b49b1413, PHP 8.3.6. Following the steps in T15790 and tryselecting to m"Manage/edit the p Panel > Edit Panel again" on the panel which throwsew an exception at creation, I get: ```[2024-04-18 17:35:03] ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/dashboard/editfield/PhabricatorDashboardQueryPanelQueryEditField.php:41] arcanist(head=master, ref.master=ef73b12b580e), phorge(head=master, ref.master=5444e1c885c3) #0 PhabricatorDashboardQueryPanelQueryEditField::newControl() called at [<phorge>/src/applications/transactions/editfield/PhabricatorEditField.php:352] #1 PhabricatorEditField::buildControl() called at [<phorge>/src/applications/transactions/editfield/PhabricatorEditField.php:385] #2 PhabricatorEditField::renderControl() called at [<phorge>/src/applications/transactions/editfield/PhabricatorEditField.php:415] #3 PhabricatorEditField::appendToForm(AphrontFormView) called at [<phorge>/src/applications/transactions/editengine/PhabricatorEditEngine.php:1386] #4 PhabricatorEditEngine::buildEditForm(PhabricatorDashboardPanel, array) called at [<phorge>/src/applications/transactions/editengine/PhabricatorEditEngine.php:1242] #5 PhabricatorEditEngine::buildEditResponse(PhabricatorDashboardPanel) called at [<phorge>/src/applications/transactions/editengine/PhabricatorEditEngine.php:1000] #6 PhabricatorEditEngine::buildResponse() called at [<phorge>/src/applications/dashboard/controller/panel/PhabricatorDashboardPanelEditController.php:66] #7 PhabricatorDashboardPanelEditController::handleRequest(AphrontRequest) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:284] #8 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:203] #9 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phorge>/webroot/index.php:35] [2024-04-18 17:35:03] ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/dashboard/editfield/PhabricatorDashboardQueryPanelQueryEditField.php:59] arcanist(head=master, ref.master=ef73b12b580e), phorge(head=master, ref.master=5444e1c885c3) #0 PhabricatorDashboardQueryPanelQueryEditField::newControl() called at [<phorge>/src/applications/transactions/editfield/PhabricatorEditField.php:352] #1 PhabricatorEditField::buildControl() called at [<phorge>/src/applications/transactions/editfield/PhabricatorEditField.php:385] #2 PhabricatorEditField::renderControl() called at [<phorge>/src/applications/transactions/editfield/PhabricatorEditField.php:415] #3 PhabricatorEditField::appendToForm(AphrontFormView) called at [<phorge>/src/applications/transactions/editengine/PhabricatorEditEngine.php:1386] #4 PhabricatorEditEngine::buildEditForm(PhabricatorDashboardPanel, array) called at [<phorge>/src/applications/transactions/editengine/PhabricatorEditEngine.php:1242] #5 PhabricatorEditEngine::buildEditResponse(PhabricatorDashboardPanel) called at [<phorge>/src/applications/transactions/editengine/PhabricatorEditEngine.php:1000] #6 PhabricatorEditEngine::buildResponse() called at [<phorge>/src/applications/dashboard/controller/panel/PhabricatorDashboardPanelEditController.php:66] #7 PhabricatorDashboardPanelEditController::handleRequest(AphrontRequest) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:284] #8 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:203] #9 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phorge>/webroot/index.php:35] ```