Change Details

It would be nice to make the "Do nothing" Herald rule a bit more self-explaining. To me, "do nothing" means, nothing is changed. But probably, this rule means "Skip main action" or something like that. [ ] understand the intended purpose of `HeraldDoNothingAction.php` [ ] eventually improve `getHeraldActionName()` from "Do nothing" to "Skip main action" Context: - https://secure.phabricator.com/D13646 - Make Herald action modularization more aggressive (created the `HeraldDoNothingAction.php`) - https://secure.phabricator.com/D13178 - Make ACTION_NOTHING a "standard" action in Herald - ...

It would be nice to make the "Do nothing" Herald Action a bit more self-explaining. To me, "do nothing" means, nothing is changed. But probably, this rule means "Skip main action" or something like that. [ ] understand the intended purpose of `HeraldDoNothingAction.php` [ ] eventually improve `getHeraldActionName()` from "Do nothing" to "Skip main action" Context: - https://secure.phabricator.com/D13646 - Make Herald action modularization more aggressive (created the `HeraldDoNothingAction.php`) - https://secure.phabricator.com/D13178 - Make ACTION_NOTHING a "standard" action in Herald - ...

It would be nice to make the "Do nothing" Herald ruleAction a bit more self-explaining. To me, "do nothing" means, nothing is changed. But probably, this rule means "Skip main action" or something like that. [ ] understand the intended purpose of `HeraldDoNothingAction.php` [ ] eventually improve `getHeraldActionName()` from "Do nothing" to "Skip main action" Context: - https://secure.phabricator.com/D13646 - Make Herald action modularization more aggressive (created the `HeraldDoNothingAction.php`) - https://secure.phabricator.com/D13178 - Make ACTION_NOTHING a "standard" action in Herald - ...