Change Details

This edit should fix completely these Phorge components in PHP 8.2: - scripts - aphront - project As usual, the risk of this change is that exceptions may occur due to really weird stuff coming in as input. In any case, if it happens, it must be evaluated on a case-by-case basis, because in this case, the previously present code (strlen) didn't make sense anyway either. Closes T15223 Ref T15190 Ref T15064

This is a fix for PHP 8.1 deprecation of strlen(NULL), from these Phorge components: - scripts - aphront - project The strlen() was used in Phabricator to check if a generic value was a string and not empty. For this reason, we adopt phutil_nonempty_string() that does exactly that. Note: this may highlight other absurd input values that might be worth correcting in the instead of just ignoring. If your phutil_nonempty_string() throws an exception, just report it to Phorge to fix together that specific corner case. Thank you. Closes T15223 Ref T15190 Ref T15064

This edit should fix completelyis a fix for PHP 8.1 deprecation of strlen(NULL), from these Phorge components in PHP 8.2:: - scripts - aphront - project AThe strlen() was usual, the risk of this change is that exceptions may occur due toed in Phabricator to check if a generic value was a string and not empty. really weird stuff coming in as input.For this reason, In any case, if it happens,we adopt phutil_nonempty_string() that does exactly that. Note: this may highlight other absurd input values that might be worth correcting in the it minstead of just be evaluated on a case-by-case basisignoring. If your phutil_nonempty_string() throws an exception, because in this case,just report the previously present code (strlen) didn't make sense anyway eitherit to Phorge to fix together that specific corner case. Thank you. Closes T15223 Ref T15190 Ref T15064