Premise: the Config page runs git commands. Spoiler: they can fail.
Before this change, errors were just suppressed and ignored.
Probably suppressing stuff was fine in the moment git worked here. But nowadays
git doesn't work so easily here, since it introduced very weird additional
configurations in order for a repository to be indicated as "safe" or not.
Error suppression was a problem there, because understanding the error with
"future objects" is not trivial for most users. Really.
After this change, these errors are beautifully mentioned in the standard log
of your webserver, to the best of our communication ability (which is not so great,
since we are computer lovers after all, so we express ourselves as we can - sorry).
This is a cute example of a new log line:
PHLOG: Cannot open git log.
Command: git log --format='%H %ct' -n 1 --
Exit: 128
Error: fatal: detected dubious ownership in repository at '/var/www/arcanist'
To add an exception for this directory, call:
git config --global --add safe.directory /var/www/arcanist
at [/src/applications/config/controller/PhabricatorConfigConsoleController.php:284]
This is another example of a new cute log line:
PHLOG: Cannot identify git remotes.
Command: git remote -v
Exit: 128
Error: fatal: detected dubious ownership in repository at '/var/www/phorge'
To add an exception for this directory, call:
git config --global --add safe.directory /var/www/phorge'
at [/src/applications/config/controller/PhabricatorConfigConsoleController.php:205]
Incidentally, these specific git errors are the ones that probably afflicts your
Phorge/Phabricator as well. So it would be nice to discuss your case in T15282
instead of putting our head inside the honey pot, or any other comfort zone.
Closes T15243