Change Details

Fix the "Update Patch" workflow on a generic Differential revision (like Diff 123). For example, this happens when you help a coworker to update their patch. So, if you visit Diff 123 and you click "Update Patch", you arrive here: https://we.phorge.it/differential/diff/9876/?revisionID=123 That page as default suggests some Diffs that are yours. Plus, it should show the current Diff. After this change the current Diff is finally available, even if it's not yours, as soon as you can View and Edit that. Any follow-up change is welcome to modernize the selector using AphrontFormTokenizerControl. Closes T15538

Fix "Update Patch" for generic Differential revisions. You can now help a coworker to update their patch, from the web. So, if you visit Diff 111 (not yours) and you click "Update Diff", and you paste a valid diff, you arrive here: https://we.phorge.it/differential/diff/222/?revisionID=111 That page as default was suggesting some Diffs that are yours. Plus, now it shows Diff 111. Omitting the Diff from which the workflow was started made no sense and it's certainly an oversight. Any follow-up change is welcome to modernize the selector using AphrontFormTokenizerControl. Closes T15538

Fix the "Update Patch" workflow on afor generic Differential revision (like Diff 123)s. For exampleYou can now help a coworker to update their patch, this happens when you help a coworker to updatefrom their patch web. So, if you visit Diff 123111 (not yours) and you click "Update Patch"Diff", and you paste a valid diff, you arrive here: https://we.phorge.it/differential/diff/9876222/?revisionID=12311 That page as default was suggestsing some Diffs that are yours. Plus, it shouldnow it show the current Diffs Diff 111. After this change the currentOmitting the Diff is finally available, even if it's not yours, as soon as you can View and Edit thatfrom which the workflow was started made no sense and it's certainly an oversight. Any follow-up change is welcome to modernize the selector using AphrontFormTokenizerControl. Closes T15538