If your Config page was showing some "Unknown" fields, this change is useful,
since it allows you to fix your situation from the .gitconfig of the
user running your webserver.
Before this change, some git commands here were executed without any HOME, so,
git was not opening any .gitconfig, so, any repository marked as "safe" was just
not assumed as safe, so, git was quitting with the exit status 128 with the famous
"detected dubious ownership" error, so, Phorge was not able to run "git log" and
identify the current version, so, Phorge was showing an "Unknown" version.
After this change, these git commands now have the HOME.
You could definitely still have that error. But at least, now you can fix.
After this change, in most cases, git will try to open this file:
/var/www/.gitconfig
So if you want to fix the "detected dubious ownership", now that file is considered,
so you can try to fix with these commands or similar ones:
# create the gitconfig file for the webserver user (this is usually its home)
sudo touch /var/www/.gitconfig
sudo chown www-data: /var/www/.gitconfig
# mark these git repositories as safe (for the perspective of the webserver user)
sudo -u www-data git config --global --add safe.directory /var/www/arcanist
sudo -u www-data git config --global --add safe.directory /var/www/phorge
# harden again
sudo chown root: /var/www/.gitconfig
This is only an indication for you related to git, and not really to Phorge.
So in short:
- you create the git config file for your webserver user
- you assign that file to your webserver user (so it can write into that)
- you login with your webserver user, and save a config, to mark as safe arcanist+phorge
- you harden again the git config file so that the webserver user cannot write in that
Probably a similar indication is in your log files.
In any case, don't just do random things. Call your systems engineer in doubt.
Closes T15299
Ref T15282
Ref T15281
Ref T15298