Change Details

This is a fix for PHP 8.1 deprecation of strlen(NULL), for these Phorge components: - src/view - src/infrastructure (partial, needs more patches) The strlen() was used in Phabricator to check if a generic value was a string and not empty. For this reason, we adopt phutil_nonempty_string() that does exactly that. Note: this may highlight other absurd input values that might be worth correcting instead of just ignoring. If your phutil_nonempty_string() throws an exception, just report it to Phorge to fix together that specific corner case. Ref T15190 Ref T15064

This is a fix for PHP 8.1 deprecation of strlen(NULL), for these Phorge components: - src/view - src/infrastructure (partial, needs more patches) The strlen() was used in Phabricator to check if a generic value was a non-empty string. For this reason, Phorge adopts phutil_nonempty_string() that checks that. Note: this may highlight other absurd input values that might be worth correcting instead of just ignoring. If your phutil_nonempty_string() throws an exception, just report it to Phorge to evaluate and fix together that specific corner case. Ref T15190 Ref T15064

This is a fix for PHP 8.1 deprecation of strlen(NULL), for these Phorge components: - src/view - src/infrastructure (partial, needs more patches) The strlen() was used in Phabricator to check if a generic value was a string and notnon-empty string. empty. For this reason, wPhorge adopts phutil_nonempty_string() that does exactlychecks that. Note: this may highlight other absurd input values that might be worth correcting instead of just ignoring. If your phutil_nonempty_string() throws an exception, just report it to Phorge to evaluate and fix together that specific corner case. Ref T15190 Ref T15064