Change Details

I noticed that setDownload() can also be called with false, true, or other weird values. So, this change continues to give full compatibility to PHP 8.1 but without putting extra input rigidity and so keeping maximum backward compatibility. This also adds a bit of inline documentation to put this more explicit. For more context see the previous change: {96ae4ba13acbf0e2f8932e950a92af0495f034d7} As already said, if your Phorge gives an exception caused by the function phutil_nonempty_string() added here and there, please report that to Phorge so we can handle that specific corner case and adopt a cleaner logic, just like this specific case. Ref T15190

I noticed that - historically - setDownload() could also be used to accept whatever weird value (like false, 0, etc.) to activate a download, and then assuming a nice default only for empty strings. So, this change continues to give full compatibility to PHP 8.1 but restoring this (weird?) behavior. This also adds a bit of inline documentation to put this thing more explicit. For more context see the previous version: {5952b0a31b6aac0718bc23aefe43560b9bfe8cc5} See also the change that did not intend to affect this behavior: {96ae4ba13acbf0e2f8932e950a92af0495f034d7} Ref T15190

I noticed that - historically - setDownload() canould also be called with false, true,used to accept or othwhatever weird values.e (like false, 0, Soetc.) to activate a download, this change continues to give fulland then compatibility to PHP 8.1 but without putting extra input rigidityassuming a nice default only for empty strings. and so keeping maximum backwardSo, this change continues to give full compatibility to PHP 8.1 but restoring this (weird?) behavior. This also adds a bit of inline documentation to put this thing more explicit. For more context see the previous change:version: {96ae4ba13acbf0e2f8932e950a92af0495f034d7}{5952b0a31b6aac0718bc23aefe43560b9bfe8cc5} As already said, if your Phorge gives an exception caused by the function phutil_nonempty_string() added here and there, please report that to Phorge so we can handle that specific corner case and adopt a cleaner logic, just like this specific case.See also the change that did not intend to affect this behavior: {96ae4ba13acbf0e2f8932e950a92af0495f034d7} Ref T15190