Premise: the Config page runs git commands. Spoiler: they can fail.
Before this change errors were just suppressed and ignored.
Probably suppressing stuff was fine in the moment git worked here. But nowadays
git doesn't work so easily here, since it introduced very weird additional
configurations in order for a repository to be indicated as "safe" or not.
Error suppression was a problem there, because understanding the error with
"future objects" is not trivial for most users. Really.
After this change, these errors are beautifully mentioned in the standard log
of your webserver, to the best of our communication ability.
This is a cute example of a new log line:
EXCEPTION: (CommandException)
Command failed with error #128!
COMMAND
git remote -v
STDOUT
(empty)
STDERR
fatal: detected dubious ownership in repository at '/var/www/phorge'
To add an exception for this directory, call:
git config --global --add safe.directory /var/www/phorge
at [<arcanist>/src/future/exec/ExecFuture.php:436]
Incidentally, that specific git error probably afflicts your Phorge/Phabricator.
So, it would be nice to discuss your case in T15282 instead of putting
our head inside an honey pot, or hiding this problem in any similar comfort zone.
Closes T15243