Change Details

I am unfortunately unable to test CircleCI specifically and would welcome if someone could give it a shot if they have or know of a project using it. Nevertheless, I am able to use the generic parts to integrate with gitlab's CI, and the circle code is just moved around, so all in all, this is probably alright.

>>! In D25011#404, @deadalnix wrote: > So I setup an instance and a dummy project with CircleCI integration. > > The good: it works for revisions, with and without this patch. > The bad: it doesn't work for tags, with and without this patch. > > I suspect the problem is on Circle's side, because it trigger an error 500, including using the exemple provided by circle in their own spec using curl, so it seems like this is broken on circle's side, and there is not much I can do here. > > I was able to verify that the behavior from this code and the old code is indeed the same. Nevertheless, I am able to use the generic parts to integrate with gitlab's CI, and the circle code is just moved around, so all in all, this is probably alright.

I am unfortunately unable to test CircleCI specifically and would welcome if someone could give it a shot if they have or know of a project using it.>>! In D25011#404, @deadalnix wrote: > So I setup an instance and a dummy project with CircleCI integration. > > The good: it works for revisions, with and without this patch. > The bad: it doesn't work for tags, with and without this patch. > > I suspect the problem is on Circle's side, because it trigger an error 500, including using the exemple provided by circle in their own spec using curl, so it seems like this is broken on circle's side, and there is not much I can do here. > > I was able to verify that the behavior from this code and the old code is indeed the same. Nevertheless, I am able to use the generic parts to integrate with gitlab's CI, and the circle code is just moved around, so all in all, this is probably alright.