HomePhorge

Fix an issue where Herald may fail to extract content from an empty commit

Description

Fix an issue where Herald may fail to extract content from an empty commit

Summary:
Ref T13667. The Herald "content added" rule (and other similar rules) do not correctly extract content from empty commits.

When we load an empty raw diff, return an empty changed content map.

Ref T13588. Also fix some PHP8.1 null/string stuff

Test Plan:

  • Ran "bin/repository reparse --publish <commit>", with an empty commit hash and a nonempty commit hash.
  • Reviewed Herald transcripts for general sanity.

Maniphest Tasks: T13667, T13588

Differential Revision: https://secure.phabricator.com/D21761

Details

Provenance
epriestley <git@epriestley.com>Authored on Apr 20 2022, 16:43
aviveyPushed on Tue, Jul 26, 15:02
aviveyPushed on Tue, Jul 26, 15:01
Differential Revision
D25040: merge phab/master -> phorge/master
Parents
rP2188473fa772: Fix an issue where we may "min()" an empty array when viewing a revision with…
Branches
Unknown
Tags
Unknown
Tasks
T15094: Catch up the master branch to upstream