HomePhorge

Don't consider file references inside quoted text blocks to grant "attachment…

Description

Don't consider file references inside quoted text blocks to grant "attachment intent"

Summary:
Ref T13682. This is a marginal case, but if you quote someone else's text and it has a file reference embedded in it, that isn't good enough to generate "attachment intent".

Since you need both a reference and an explicit attachment, this should never actually affect any user-visible behavior today, but makes the ruleset more thorough.

Test Plan: Dragged and dropped a file, referencing it in either a quoted or unquoted block. Saw it attach only for a quoted block.

Maniphest Tasks: T13682

Differential Revision: https://secure.phabricator.com/D21833

Details

Provenance
epriestley <git@epriestley.com>Authored on May 20 2022, 18:17
aviveyPushed on Tue, Jul 26, 15:02
aviveyPushed on Tue, Jul 26, 15:01
Parents
rP2a0feb3de0e2: Only attach files that are both referenced in Remarkup and attached by explicit…
Branches
Unknown
Tags
Unknown

Event Timeline