HomePhorge

Fix an issue where "git" may be unable to read a temporary file in Diffusion

Description

Fix an issue where "git" may be unable to read a temporary file in Diffusion

Summary:
Ref T13673. After the changes in that task, we may execute "git config -l ..." as a user other than the user we used to write this temporary file.

Use "--file -" to pass the data instead, avoiding use of temporary files. This makes us agnostic to filesystem permissions.

Test Plan: Viewed a Git repository with submodules in Diffusion with "ssh.user" configured as a user relatively isolated from the webserver user.

Maniphest Tasks: T13673

Differential Revision: https://secure.phabricator.com/D21759

Details

Provenance
epriestley <git@epriestley.com>Authored on Apr 20 2022, 16:29
aviveyPushed on Tue, Jul 26, 15:02
aviveyPushed on Tue, Jul 26, 15:01
Differential Revision
D25040: merge phab/master -> phorge/master
Parents
rP21b1a304b60a: Improve some PHP 8.1 behavior in "bin/auth recover"
Branches
Unknown
Tags
Unknown
Tasks
T15094: Catch up the master branch to upstream