HomePhorge

Fix an issue where we may "min()" an empty array when viewing a revision with…

Description

Fix an issue where we may "min()" an empty array when viewing a revision with no changesets

Summary:
Ref T13667. When a revision's diff has no changesets (usually because Diffusion performed an automatic update with an empty commit), the UI currently tries to "min()" an empty array and fatals.

Handle this case properly.

Test Plan:

  • Created a revision with a diff with no changesets ("git commit --allow-empty" + copy-paste into web UI).
  • Viewed revision.
    • Before: "min()" fatal.
    • After: UI isn't perfect, but works without fataling.

Subscribers: cspeckmim

Maniphest Tasks: T13667

Differential Revision: https://secure.phabricator.com/D21760

Details

Provenance
epriestley <git@epriestley.com>Authored on Apr 20 2022, 16:34
aviveyPushed on Tue, Jul 26, 15:02
aviveyPushed on Tue, Jul 26, 15:01
Differential Revision
D25040: merge phab/master -> phorge/master
Parents
rP52df4ff515b7: Fix an issue where "git" may be unable to read a temporary file in Diffusion
Branches
Unknown
Tags
Unknown
Tasks
T15094: Catch up the master branch to upstream