HomePhorge

Fix subtype extension support check

Description

Fix subtype extension support check

Summary: Fixes T13663. supportsSubtypes tries to create an editable object, but this isn't always valid for PhabricatorCalendarImport. Use instanceof instead.

Test Plan:

  • Edited calendar import, tasks (2 different subtypes), and projects (2 different subtypes).
  • Changed task subtypes using Change Subtype action and batch editor.
  • Changed task and project subtypes using Conduit.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Maniphest Tasks: T13663

Differential Revision: https://secure.phabricator.com/D21714

Details

Provenance
0Authored on Aug 20 2021, 22:48
aviveyPushed on Jul 26 2022, 15:02
aviveyPushed on Jul 26 2022, 15:01
Differential Revision
D25040: merge phab/master -> phorge/master
Parents
rP8daaf5ef2145: Pass a real context object to Phriction previews, fixing mentions
Branches
Unknown
Tags
Unknown
Tasks
T15094: Catch up the master branch to upstream