HomePhorge

Remove the "25% of active pool" growth rate throttle from Drydock

Description

Remove the "25% of active pool" growth rate throttle from Drydock

Summary:
Ref T13677. Drydock has a hard-coded and fairly arbitrary limit which prevents a resource pool from growing more than 25% at once.

This is vaguely reasonable for resources which allocate quickly, but suffocating for slower resources. It's also wholly arbitrary, and the "one per lease" limit introduced in D21807 should do a better job of covering the same ground while generally being more reasonable, expected, and predictable.

Test Plan: Ran Drydock allocations without the throttle, saw faster pool growth.

Subscribers: yelirekim, PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13677

Differential Revision: https://secure.phabricator.com/D21808

Details

Provenance
epriestley <git@epriestley.com>Authored on May 9 2022, 17:04
aviveyPushed on Tue, Jul 26, 15:02
aviveyPushed on Tue, Jul 26, 15:01
Differential Revision
D25040: merge phab/master -> phorge/master
Parents
rP62360ea40689: Adjust the Drydock allocator to limit each pending lease to one allocating…
Branches
Unknown
Tags
Unknown
Tasks
T15094: Catch up the master branch to upstream