HomePhorge

Fix an exception in cursor pagination of Conpherence threads

Description

Fix an exception in cursor pagination of Conpherence threads

Summary: Ref T13680. Conpherence may pass values with an integer type to this layer of the stack. These are "supposed" to be strings, but just be accepting.

Test Plan:

  • Wrote 100+ messages to a Conpherence room.
  • Clicked "Show Older Messages".
  • Before: exception, int passed to "phutil_nonempty_string()".
  • After: older messages loaded.

Maniphest Tasks: T13680

Differential Revision: https://secure.phabricator.com/D21824

Details

Provenance
epriestley <git@epriestley.com>Authored on May 17 2022, 23:07
aviveyPushed on Tue, Jul 26, 15:02
aviveyPushed on Tue, Jul 26, 15:01
Differential Revision
D25040: merge phab/master -> phorge/master
Parents
rP431612023dae: Remove "feed.publish" API
Branches
Unknown
Tags
Unknown
Tasks
T15094: Catch up the master branch to upstream