HomePhorge

Allow maintenance scripts to write synthetic events to the push log that act as…

This commit no longer exists in the repository. It may have been part of a branch which was deleted.

Description

Allow maintenance scripts to write synthetic events to the push log that act as repository updates

Summary:
Ref T13614. When a script holds the write lock but modifies the repository directly (rather than by pushing), the repository version won't change when the script releases the write lock. Thus, the writes may not propagate to other nodes (it depends which node lucks out and accepts the next write).

To guarantee that writes propagate, allow these scripts to pretend they pushed the repository. These are bare-bones valid events flagged as "Maintenance".

Test Plan:

  • Wrote a script to hold the write lock, wait (or pretend to do something), then release the write lock.
  • Applied patches, modified script to use new APIs ("newMaintenanceEvent()").
  • Ran script, saw repository verison bump and relevant push logs:

{F8814923}

Maniphest Tasks: T13614

Differential Revision: https://secure.phabricator.com/D21670

Details

Provenance
epriestley <git@epriestley.com>Authored on Jun 1 2021, 13:34

Event Timeline

Commit No Longer Exists

This commit no longer exists in the repository.