HomePhorge

Prevent embedded remarkup content from cycling when it contains embedded self…

Description

Prevent embedded remarkup content from cycling when it contains embedded self-references

Summary: Ref T13678. When remarkup content embeds other remarkup content, detect and degrade if the references have nesting depth greater than 1. This is a coarse cycle detector, since rendering shallow (but technically non-cycling) trees doesn't seem valuable.

Test Plan: Created various objects with self-references, saw everything degrade properly (after one level of embedding) when embedded in itself and in other contexts. See attached screenshot.

Maniphest Tasks: T13678

Differential Revision: https://secure.phabricator.com/D21810

Details

Provenance
epriestley <git@epriestley.com>Authored on May 9 2022, 18:18
aviveyPushed on Tue, Jul 26, 15:02
aviveyPushed on Tue, Jul 26, 15:01
Differential Revision
D25040: merge phab/master -> phorge/master
Parents
rPa640a4a4930f: In Drydock, yield for reclaiming resources in the "released" state
Branches
Unknown
Tags
Unknown
Tasks
T15094: Catch up the master branch to upstream