Page MenuHomePhorge
New Question
Ponder Q57 History

PHP 8.1 "strlen(null)" exception when running "arc diff" with no active branch

Event Timeline

jkimbo asked this question.May 22 2023, 10:40
jkimbo created this object in space S1 Public.
Herald added subscribers: Cigaryno, Matthew. · View Herald TranscriptMay 22 2023, 10:40
avivey added an answer.May 22 2023, 10:57
valerio.bozzolan subscribed.EditedMay 22 2023, 12:37

Hi @jkimbo thank you for your bug report. Now you are a Trusted Contributors. Feel free to elevate this question as a Task under PHP 8 support

As you can see from the git history of Phorge we are really hammering fixes for PHP 8.1 but this is really not ready for production as avivey said. So your report is really appreciated, but I suggest PHP 7.4 at the moment.

valerio.bozzolan awarded a token.May 22 2023, 20:06
jkimbo added a comment.May 23 2023, 08:40

@valerio.bozzolan have you added me to the Trusted Contributors group? I don't seem to have the permission to create any new tasks. Happy to create the task for this bug and the diff to fix it.

valerio.bozzolan added a comment.May 23 2023, 08:52

Whooops, added! :)

jkimbo added a comment.May 23 2023, 12:38

Thanks!

jkimbo added a comment.EditedMay 23 2023, 12:46

Created T15412 and D25237 to fix this issue.

valerio.bozzolan added a comment.May 23 2023, 20:22

If you want additional glory, feel free to add an answer below, mentioning your task and your patch. Thanks again :) and feel free to land, since it's approved now (arc land).

jkimbo added an answer.May 27 2023, 16:07
valerio.bozzolan closed this question as resolved.May 27 2023, 19:21
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0