Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F2682604
D25754.1734665209.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Advanced/Developer...
View Handle
View Hovercard
Size
563 B
Referenced Files
None
Subscribers
None
D25754.1734665209.diff
View Options
diff --git a/src/channel/PhutilChannelChannel.php b/src/channel/PhutilChannelChannel.php
--- a/src/channel/PhutilChannelChannel.php
+++ b/src/channel/PhutilChannelChannel.php
@@ -53,10 +53,12 @@
protected function readBytes($length) {
$this->throwOnRawByteOperations();
+ return ''; // Never returned but makes static code analyzers happy
}
protected function writeBytes($bytes) {
$this->throwOnRawByteOperations();
+ return -1; // Never returned but makes static code analyzers happy
}
protected function getReadSockets() {
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Fri, Dec 20, 03:26 (21 h, 24 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1016466
Default Alt Text
D25754.1734665209.diff (563 B)
Attached To
Mode
D25754: Add return statements for PhutilChannelChannel::readBytes()/writeBytes()
Attached
Detach File
Event Timeline
Log In to Comment