Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F2680487
D25733.1734556094.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Advanced/Developer...
View Handle
View Hovercard
Size
1 KB
Referenced Files
None
Subscribers
None
D25733.1734556094.diff
View Options
diff --git a/src/aphront/AphrontRequest.php b/src/aphront/AphrontRequest.php
--- a/src/aphront/AphrontRequest.php
+++ b/src/aphront/AphrontRequest.php
@@ -705,7 +705,7 @@
}
public function isPreviewRequest() {
- return $this->isFormPost() && $this->getStr('__preview__');
+ return $this->getStr('__preview__');
}
/**
diff --git a/src/applications/transactions/editengine/PhabricatorEditEngine.php b/src/applications/transactions/editengine/PhabricatorEditEngine.php
--- a/src/applications/transactions/editengine/PhabricatorEditEngine.php
+++ b/src/applications/transactions/editengine/PhabricatorEditEngine.php
@@ -1893,10 +1893,11 @@
$controller = $this->getController();
$request = $controller->getRequest();
+ $is_preview = $request->isPreviewRequest();
// NOTE: We handle hisec inside the transaction editor with "Sign With MFA"
// comment actions.
- if (!$request->isFormOrHisecPost()) {
+ if (!$request->isFormOrHisecPost() && !$is_preview) {
return new Aphront400Response();
}
@@ -1912,7 +1913,6 @@
$fields = $this->buildEditFields($object);
- $is_preview = $request->isPreviewRequest();
$view_uri = $this->getEffectiveObjectViewURI($object);
$template = $object->getApplicationTransactionTemplate();
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Wed, Dec 18, 21:08 (4 h, 46 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1014923
Default Alt Text
D25733.1734556094.diff (1 KB)
Attached To
Mode
D25733: Do not throw Aphront400Response when editing a task
Attached
Detach File
Event Timeline
Log In to Comment