No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

View Options

	diff --git a/src/lint/linter/ArcanistFutureLinter.php b/src/lint/linter/ArcanistFutureLinter.php
	index d14fe49a..e9df8371 100644
	--- a/src/lint/linter/ArcanistFutureLinter.php
	+++ b/src/lint/linter/ArcanistFutureLinter.php
	@@ -1,56 +1,56 @@
	<?php

	abstract class ArcanistFutureLinter extends ArcanistLinter {

	private $futures;

	abstract protected function buildFutures(array $paths);
	abstract protected function resolveFuture($path, Future $future);

	final protected function getFuturesLimit() {
	return 8;
	}

	- final public function willLintPaths(array $paths) {
	+ public function willLintPaths(array $paths) {
	$limit = $this->getFuturesLimit();
	$this->futures = id(new FutureIterator(array()))->limit($limit);
	foreach ($this->buildFutures($paths) as $path => $future) {
	$this->futures->addFuture($future, $path);
	}
	}

	final public function lintPath($path) {
	return;
	}

	- final public function didLintPaths(array $paths) {
	+ public function didLintPaths(array $paths) {
	if (!$this->futures) {
	return;
	}

	$map = array();
	foreach ($this->futures as $path => $future) {
	$this->setActivePath($path);
	$this->resolveFuture($path, $future);
	$map[$path] = $future;
	}
	$this->futures = array();

	$this->didResolveLinterFutures($map);
	}


	/**
	* Hook for cleaning up resources.
	*
	* This is invoked after a block of futures resolve, and allows linters to
	* discard or clean up any shared resources they no longer need.
	*
	* @param map<string, Future> Map of paths to resolved futures.
	* @return void
	*/
	protected function didResolveLinterFutures(array $futures) {
	return;
	}

	}

File Metadata

Mime Type: text/x-diff
Expires: Sun, Jan 19, 15:26 (3 w, 23 h ago)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 1125976
Default Alt Text: (1 KB)

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions