View Options

	diff --git a/src/applications/phurl/controller/PhabricatorPhurlURLViewController.php b/src/applications/phurl/controller/PhabricatorPhurlURLViewController.php
	index 4483b9bb77..1ddc2a8344 100644
	--- a/src/applications/phurl/controller/PhabricatorPhurlURLViewController.php
	+++ b/src/applications/phurl/controller/PhabricatorPhurlURLViewController.php
	@@ -1,139 +1,159 @@
	<?php

	final class PhabricatorPhurlURLViewController
	extends PhabricatorPhurlController {

	public function shouldAllowPublic() {
	return true;
	}

	public function handleRequest(AphrontRequest $request) {
	$viewer = $request->getViewer();
	$id = $request->getURIData('id');

	$timeline = null;

	$url = id(new PhabricatorPhurlURLQuery())
	->setViewer($viewer)
	->withIDs(array($id))
	->executeOne();
	if (!$url) {
	return new Aphront404Response();
	}

	$title = $url->getMonogram();
	$page_title = $title.' '.$url->getName();
	$crumbs = $this->buildApplicationCrumbs();
	$crumbs->addTextCrumb($title, $url->getURI());

	$timeline = $this->buildTransactionTimeline(
	$url,
	new PhabricatorPhurlURLTransactionQuery());

	$header = $this->buildHeaderView($url);
	$actions = $this->buildActionView($url);
	$properties = $this->buildPropertyView($url);

	$properties->setActionList($actions);
	$box = id(new PHUIObjectBoxView())
	->setHeader($header)
	->addPropertyList($properties);

	$is_serious = PhabricatorEnv::getEnvConfig('phabricator.serious-business');
	$add_comment_header = $is_serious
	? pht('Add Comment')
	: pht('More Cowbell');
	$draft = PhabricatorDraft::newFromUserAndKey($viewer, $url->getPHID());
	$comment_uri = $this->getApplicationURI(
	'/phurl/comment/'.$url->getID().'/');
	$add_comment_form = id(new PhabricatorApplicationTransactionCommentView())
	->setUser($viewer)
	->setObjectPHID($url->getPHID())
	->setDraft($draft)
	->setHeaderText($add_comment_header)
	->setAction($comment_uri)
	->setSubmitButtonName(pht('Add Comment'));

	return $this->buildApplicationPage(
	array(
	$crumbs,
	$box,
	$timeline,
	$add_comment_form,
	),
	array(
	'title' => $page_title,
	'pageObjects' => array($url->getPHID()),
	));
	}

	private function buildHeaderView(PhabricatorPhurlURL $url) {
	$viewer = $this->getViewer();
	$icon = 'fa-compress';
	$color = 'green';
	$status = pht('Active');

	$header = id(new PHUIHeaderView())
	->setUser($viewer)
	->setHeader($url->getName())
	->setStatus($icon, $color, $status)
	->setPolicyObject($url);

	return $header;
	}

	private function buildActionView(PhabricatorPhurlURL $url) {
	$viewer = $this->getViewer();
	$id = $url->getID();

	$actions = id(new PhabricatorActionListView())
	->setObjectURI($url->getURI())
	->setUser($viewer)
	->setObject($url);

	$can_edit = PhabricatorPolicyFilter::hasCapability(
	$viewer,
	$url,
	PhabricatorPolicyCapability::CAN_EDIT);

	- $actions->addAction(
	- id(new PhabricatorActionView())
	- ->setName(pht('Edit'))
	- ->setIcon('fa-pencil')
	- ->setHref($this->getApplicationURI("url/edit/{$id}/"))
	- ->setDisabled(!$can_edit)
	- ->setWorkflow(!$can_edit));
	+ $allowed_protocols = PhabricatorEnv::getEnvConfig('uri.allowed-protocols');
	+ $uri = new PhutilURI($url->getLongURL());
	+ $url_protocol = $uri->getProtocol();
	+
	+ $can_access = false;
	+ $redirect_uri = $url->getMonogram();
	+
	+ if (strlen($url_protocol)) {
	+ $can_access = in_array($url_protocol, $allowed_protocols);
	+ $redirect_uri = $uri;
	+ }
	+
	+ $actions
	+ ->addAction(
	+ id(new PhabricatorActionView())
	+ ->setName(pht('Edit'))
	+ ->setIcon('fa-pencil')
	+ ->setHref($this->getApplicationURI("url/edit/{$id}/"))
	+ ->setDisabled(!$can_edit)
	+ ->setWorkflow(!$can_edit))
	+ ->addAction(
	+ id(new PhabricatorActionView())
	+ ->setName(pht('Visit URL'))
	+ ->setIcon('fa-external-link')
	+ ->setHref($redirect_uri)
	+ ->setDisabled(!$can_edit \|\| !$can_access)
	+ ->setWorkflow(!$can_edit));

	return $actions;
	}

	private function buildPropertyView(PhabricatorPhurlURL $url) {
	$viewer = $this->getViewer();

	$properties = id(new PHUIPropertyListView())
	->setUser($viewer)
	->setObject($url);

	$properties->addProperty(
	pht('Original URL'),
	$url->getLongURL());

	$properties->invokeWillRenderEvent();

	if (strlen($url->getDescription())) {
	$description = PhabricatorMarkupEngine::renderOneObject(
	id(new PhabricatorMarkupOneOff())->setContent($url->getDescription()),
	'default',
	$viewer);

	$properties->addSectionHeader(
	pht('Description'),
	PHUIPropertyListView::ICON_SUMMARY);

	$properties->addTextContent($description);
	}

	return $properties;
	}

	}

File Metadata

Mime Type: text/x-diff
Expires: Sun, Jan 19, 19:48 (1 w, 4 d ago)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 1128134
Default Alt Text: (5 KB)

No OneTemporary
Actions

View Options

File Metadata

Event Timeline

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions