View Options

	diff --git a/src/applications/transactions/xaction/PhabricatorEditEngineSubtypeTransaction.php b/src/applications/transactions/xaction/PhabricatorEditEngineSubtypeTransaction.php
	index 53ec221631..a2a8538115 100644
	--- a/src/applications/transactions/xaction/PhabricatorEditEngineSubtypeTransaction.php
	+++ b/src/applications/transactions/xaction/PhabricatorEditEngineSubtypeTransaction.php
	@@ -1,48 +1,67 @@
	<?php

	final class PhabricatorEditEngineSubtypeTransaction
	extends PhabricatorEditEngineTransactionType {

	const TRANSACTIONTYPE = 'editengine.config.subtype';

	public function generateOldValue($object) {
	return $object->getSubtype();
	}

	public function applyInternalEffects($object, $value) {
	$object->setSubtype($value);
	}

	public function getTitle() {
	$old = $this->getOldValue();
	$new = $this->getNewValue();

	return pht(
	'%s changed the subtype of this form from %s to %s.',
	$this->renderAuthor(),
	$this->renderOldValue(),
	$this->renderNewValue());
	}

	public function validateTransactions($object, array $xactions) {
	- $map = $object->getEngine()
	+ $errors = array();
	+
	+ if (!$xactions) {
	+ return $errors;
	+ }
	+
	+ $engine = $object->getEngine();
	+
	+ if (!$engine->supportsSubtypes()) {
	+ foreach ($xactions as $xaction) {
	+ $errors[] = $this->newInvalidError(
	+ pht(
	+ 'Edit engine (of class "%s") does not support subtypes, so '.
	+ 'subtype transactions can not be applied to it.',
	+ get_class($engine)),
	+ $xaction);
	+ }
	+ return $errors;
	+ }
	+
	+ $map = $engine
	->setViewer($this->getActor())
	->newSubtypeMap();

	- $errors = array();
	foreach ($xactions as $xaction) {
	$new = $xaction->getNewValue();

	if ($map->isValidSubtype($new)) {
	continue;
	}

	$errors[] = $this->newInvalidError(
	pht('Subtype "%s" is not a valid subtype.', $new),
	$xaction);
	}

	return $errors;
	}

	}

File Metadata

Mime Type: text/x-diff
Expires: Mon, Mar 24, 09:39 (3 w, 3 d ago)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 1130951
Default Alt Text: (2 KB)

No OneTemporary
Actions

View Options

File Metadata

Event Timeline

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions