View Options

	diff --git a/src/workflow/ArcanistCloseWorkflow.php b/src/workflow/ArcanistCloseWorkflow.php
	index b9b10bf6..aa5ac10c 100644
	--- a/src/workflow/ArcanistCloseWorkflow.php
	+++ b/src/workflow/ArcanistCloseWorkflow.php
	@@ -1,127 +1,147 @@
	<?php

	/**
	* Close a task
	*
	* @group workflow
	*/
	final class ArcanistCloseWorkflow extends ArcanistBaseWorkflow {

	private $tasks;
	- private $statusOptions = array(
	- "resolved" => 1,
	- "wontfix" => 2,
	- "invalid" => 3,
	- "duplicate" => 4,
	- "spite" => 5,
	- "open" => 0
	- );
	+ private $statusOptions;
	+ private $statusData;
	+
	+ private function loadStatusData() {
	+ $this->statusData = $this->getConduit()->callMethodSynchronous(
	+ 'maniphest.querystatuses',
	+ array());
	+ return $this;
	+ }

	+ private function getStatusOptions() {
	+ if ($this->statusData === null) {
	+ throw new Exception('loadStatusData first!');
	+ }
	+ return idx($this->statusData, 'statusMap');
	+ }
	+ private function getDefaultClosedStatus() {
	+ if ($this->statusData === null) {
	+ throw new Exception('loadStatusData first!');
	+ }
	+ return idx($this->statusData, 'defaultClosedStatus');
	+ }

	public function getWorkflowName() {
	return 'close';
	}

	public function getCommandSynopses() {
	return phutil_console_format(<<<EOTEXT
	close __task_id__ [__options__]
	EOTEXT
	);
	}

	public function getCommandHelp() {
	return phutil_console_format(<<<EOTEXT
	- Close a task.
	+ Close a task or otherwise update its status.
	EOTEXT
	);
	}

	public function requiresConduit() {
	return true;
	}

	public function requiresRepositoryAPI() {
	return false;
	}

	public function requiresAuthentication() {
	return true;
	}


	public function getArguments() {
	- $options = array_keys($this->statusOptions);
	- $last = array_pop($options);
	return array(
	'*' => 'task_id',
	'message' => array(
	'short' => 'm',
	'param' => 'comment',
	- 'help' => "Provide a comment with your status change.",
	+ 'help' => pht('Provide a comment with your status change.'),
	),
	'status' => array(
	'param' => 'status',
	'short' => 's',
	- 'help' => "New status. Valid options are ".
	- implode(', ', $options).", or {$last}. Default is resolved.\n"
	+ 'help' => pht('Specify a new status. Valid status options can be '.
	+ 'seen with the `list-statuses` argument.'),
	+ ),
	+ 'list-statuses' => array(
	+ 'help' => 'Show available status options and exit.',
	),
	);
	}

	public function run() {
	+ $this->loadStatusData();
	+ $list_statuses = $this->getArgument('list-statuses');
	+ if ($list_statuses) {
	+ echo phutil_console_format(pht(
	+ "Valid status options are:\n".
	+ "\t%s\n", implode($this->getStatusOptions(), ', ')));
	+ return 0;
	+ }
	$ids = $this->getArgument('task_id');
	$message = $this->getArgument('message');
	$status = strtolower($this->getArgument('status'));

	+ $status_options = $this->getStatusOptions();
	if (!isset($status) \|\| $status == '') {
	- $status = head_key($this->statusOptions);
	+ $status = $this->getDefaultClosedStatus();
	}

	- if (isset($this->statusOptions[$status])) {
	- $status = $this->statusOptions[$status];
	- } else {
	- $options = array_keys($this->statusOptions);
	+ if (!isset($status_options[$status])) {
	+ $options = array_keys($status_options);
	$last = array_pop($options);
	echo "Invalid status {$status}, valid options are ".
	implode(', ', $options).", or {$last}.\n";
	return;
	}

	foreach ($ids as $id) {
	if (!preg_match("/^T?\d+$/", $id)) {
	echo "Invalid Task ID: {$id}.\n";
	return 1;
	}
	$id = ltrim($id, 'T');
	$result = $this->closeTask($id, $status, $message);
	- $status_options = array_flip($this->statusOptions);
	$current_status = $status_options[$status];
	if ($result) {
	echo "T{$id}'s status is now set to {$current_status}.\n";
	} else {
	echo "T{$id} is already set to {$current_status}.\n";
	}
	}
	return 0;
	}

	- private function closeTask($task_id, $status = 1, $comment = "") {
	+ private function closeTask($task_id, $status, $comment = "") {
	$conduit = $this->getConduit();
	$info = $conduit->callMethodSynchronous(
	'maniphest.info',
	array(
	'task_id' => $task_id
	));
	if ($info['status'] == $status) {
	return false;
	}
	return $conduit->callMethodSynchronous(
	'maniphest.update',
	array(
	'id' => $task_id,
	'status' => $status,
	'comments' => $comment
	));
	}

	}

File Metadata

Mime Type: text/x-diff
Expires: Jan 19 2025, 22:30 (6 w, 3 d ago)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 1129424
Default Alt Text: (4 KB)

No OneTemporary
Actions

View Options

File Metadata

Event Timeline

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions