Page MenuHomePhorge
Files F2892039

No OneTemporary
Actions

View Options

diff --git a/src/applications/config/check/PhabricatorSetupCheckMySQL.php b/src/applications/config/check/PhabricatorSetupCheckMySQL.php
index a4cefc46b0..9b4c4581a6 100644
--- a/src/applications/config/check/PhabricatorSetupCheckMySQL.php
+++ b/src/applications/config/check/PhabricatorSetupCheckMySQL.php
@@ -1,54 +1,63 @@
<?php
final class PhabricatorSetupCheckMySQL extends PhabricatorSetupCheck {
protected function executeChecks() {
$conn_raw = id(new PhabricatorUser())->establishConnection('w');
$max_allowed_packet = queryfx_one(
$conn_raw,
'SHOW VARIABLES LIKE %s',
'max_allowed_packet');
$max_allowed_packet = idx($max_allowed_packet, 'Value', PHP_INT_MAX);
$recommended_minimum = 1024 * 1024;
if ($max_allowed_packet < $recommended_minimum) {
$message = pht(
"MySQL is configured with a very small 'max_allowed_packet' (%d), ".
"which may cause some large writes to fail. Strongly consider raising ".
"this to at least %d in your MySQL configuration.",
$max_allowed_packet,
$recommended_minimum);
$this->newIssue('mysql.max_allowed_packet')
->setName(pht('Small MySQL "max_allowed_packet"'))
->setMessage($message);
}
- if (PhabricatorEnv::getEnvConfig('phabricator.developer-mode')) {
- $mode_string = queryfx_one($conn_raw, "SELECT @@sql_mode");
- $modes = explode(',', $mode_string['@@sql_mode']);
- if (!in_array('STRICT_ALL_TABLES', $modes)) {
- $summary = pht(
- "MySQL is not in strict mode, but should be for Phabricator ".
- "development.");
-
- $message = pht(
- "This install is in developer mode, but the global sql_mode is not ".
- "set to 'STRICT_ALL_TABLES'. It is recommended that you set this ".
- "mode while developing Phabricator. Strict mode will promote some ".
- "query warnings to errors, and ensure you don't miss them during ".
- "development. You can find more information about this mode (and ".
- "how to configure it) in the MySQL manual.");
-
- $this->newIssue('mysql.mode')
- ->setName(pht('MySQL STRICT_ALL_TABLES Mode Not Set'))
- ->addRelatedPhabricatorConfig('phabricator.developer-mode')
- ->setSummary($summary)
- ->setMessage($message);
- }
- }
+ $mode_string = queryfx_one($conn_raw, "SELECT @@sql_mode");
+ $modes = explode(',', $mode_string['@@sql_mode']);
+ if (!in_array('STRICT_ALL_TABLES', $modes)) {
+ $summary = pht(
+ "MySQL is not in strict mode, but using strict mode is strongly ".
+ "encouraged.");
+ $message = pht(
+ "On your MySQL instance, the global sql_mode is not set to ".
+ "'STRICT_ALL_TABLES'. It is strongly encouraged that you enable this ".
+ "mode when running Phabricator.\n\n".
+ "By default, MySQL will fail silently and continue when certain ".
+ "error conditions occur. Sometimes contuining does the wrong thing. ".
+ "For example, inserting too much data into a column will cause ".
+ "silent truncation (and thus data loss) instead of failing in an ".
+ "obvious way that we can fix. These behaviors can also create ".
+ "security risks. Enabling strict mode raises an explicit error ".
+ "instead and prevents this entire class of problem from doing any ".
+ "damage.\n\n".
+ "You can find more information about this mode (and how to configure ".
+ "it) in the MySQL manual. Usually, it is sufficient to add this to ".
+ "your 'my.cnf' file:\n\n".
+ "%s\n".
+ "(Note that if you run other applications against the same database, ".
+ "they may not work in strict mode. Be careful about enabling it in ".
+ "these cases.)",
+ phutil_tag('pre', array(), 'sql-mode=STRICT_ALL_TABLES'));
+
+ $this->newIssue('mysql.mode')
+ ->setName(pht('MySQL STRICT_ALL_TABLES Mode Not Set'))
+ ->setSummary($summary)
+ ->setMessage($message);
+ }
}
}

File Metadata

Mime Type
text/x-diff
Expires
Sun, Jan 19, 16:08 (2 w, 6 d ago)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1126329
Default Alt Text
(4 KB)

Event Timeline

Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0