Page MenuHomePhorge
Files F2895826

No OneTemporary
Actions

View Options

diff --git a/src/lint/linter/ArcanistPhpLinter.php b/src/lint/linter/ArcanistPhpLinter.php
index 789e2e8d..438cfe6e 100644
--- a/src/lint/linter/ArcanistPhpLinter.php
+++ b/src/lint/linter/ArcanistPhpLinter.php
@@ -1,81 +1,109 @@
<?php
/**
* Uses "php -l" to detect syntax errors in PHP code.
*/
final class ArcanistPhpLinter extends ArcanistExternalLinter {
+ const LINT_PARSE_ERROR = 1;
+ const LINT_FATAL_ERROR = 2;
+
public function getInfoName() {
return 'php -l';
}
public function getInfoURI() {
return 'http://php.net/';
}
public function getInfoDescription() {
- return pht(
- 'Checks for syntax errors in php files.');
+ return pht('Checks for syntax errors in PHP files.');
}
public function getLinterName() {
return 'PHP';
}
public function getLinterConfigurationName() {
return 'php';
}
+ public function getLintNameMap() {
+ return array(
+ self::LINT_PARSE_ERROR => pht('Parse Error'),
+ self::LINT_FATAL_ERROR => pht('Fatal Error'),
+ );
+ }
+
protected function getMandatoryFlags() {
return array('-l');
}
public function getInstallInstructions() {
return pht('Install PHP.');
}
public function getDefaultBinary() {
return 'php';
}
public function getVersion() {
list($stdout) = execx(
'%C --run %s',
$this->getExecutableCommand(),
'echo phpversion();');
return $stdout;
}
public function shouldExpectCommandErrors() {
return true;
}
public function supportsReadDataFromStdin() {
return false;
}
+ protected function canCustomizeLintSeverities() {
+ return false;
+ }
+
protected function parseLinterOutput($path, $err, $stdout, $stderr) {
- // Older versions of php had both on $stdout, newer ones split it
- // Combine $stdout and $stderr for consistency
+ // Older versions of PHP had both on stdout, newer ones split it.
+ // Combine stdout and stderr for consistency.
$stdout = $stderr."\n".$stdout;
$matches = array();
- $regex = '/^(?<type>.+?) error:\s+(?<error>.*?)\s+in\s+(?<file>.*?)'.
- '\s+on line\s+(?<line>\d*)$/m';
+
+ $regex = '/^(PHP )?(?<type>.+) error: +(?<error>.+) in (?<file>.+) '.
+ 'on line (?<line>\d+)$/m';
if (preg_match($regex, $stdout, $matches)) {
- $type = strtolower($matches['type']);
- $message = new ArcanistLintMessage();
- $message->setPath($matches['file']);
- $message->setLine($matches['line']);
- $message->setCode('php.'.$type);
- $message->setDescription('This file contains a '.$type.' error: '.
- $matches['error'].' on line '.$matches['line']);
- $message->setSeverity(ArcanistLintSeverity::SEVERITY_ERROR);
-
- // php -l only returns the first error
+ $code = $this->getLintCodeFromLinterConfigurationKey($matches['type']);
+
+ $message = id(new ArcanistLintMessage())
+ ->setPath($path)
+ ->setLine($matches['line'])
+ ->setCode($this->getLinterName().$code)
+ ->setName($this->getLintMessageName($code))
+ ->setSeverity(ArcanistLintSeverity::SEVERITY_ERROR)
+ ->setDescription($matches['error']);
+
+ // `php -l` only returns the first error.
return array($message);
}
return array();
}
+ protected function getLintCodeFromLinterConfigurationKey($code) {
+ switch (phutil_utf8_strtolower($code)) {
+ case 'parse':
+ return self::LINT_PARSE_ERROR;
+
+ case 'fatal':
+ return self::LINT_FATAL_ERROR;
+
+ default:
+ throw new Exception(pht('Unrecognized lint message code "%s"', $code));
+ }
+ }
+
}

File Metadata

Mime Type
text/x-diff
Expires
Jan 19 2025, 22:06 (6 w, 2 d ago)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1129236
Default Alt Text
(3 KB)

Event Timeline

Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0