View Options

	diff --git a/src/applications/harbormaster/storage/build/HarbormasterBuildLintMessage.php b/src/applications/harbormaster/storage/build/HarbormasterBuildLintMessage.php
	index 2bd37b2f79..4fe230d452 100644
	--- a/src/applications/harbormaster/storage/build/HarbormasterBuildLintMessage.php
	+++ b/src/applications/harbormaster/storage/build/HarbormasterBuildLintMessage.php
	@@ -1,159 +1,159 @@
	<?php

	final class HarbormasterBuildLintMessage
	extends HarbormasterDAO {

	protected $buildTargetPHID;
	protected $path;
	protected $line;
	protected $characterOffset;
	protected $code;
	protected $severity;
	protected $name;
	protected $properties = array();

	private $buildTarget = self::ATTACHABLE;

	public static function initializeNewLintMessage(
	HarbormasterBuildTarget $build_target) {
	return id(new HarbormasterBuildLintMessage())
	->setBuildTargetPHID($build_target->getPHID());
	}

	public static function getParameterSpec() {
	return array(
	'name' => array(
	'type' => 'string',
	'description' => pht(
	'Short message name, like "Syntax Error".'),
	),
	'code' => array(
	'type' => 'string',
	'description' => pht(
	'Lint message code identifying the type of message, like "ERR123".'),
	),
	'severity' => array(
	'type' => 'string',
	'description' => pht(
	'Severity of the message.'),
	),
	'path' => array(
	'type' => 'string',
	'description' => pht(
	'Path to the file containing the lint message, from the project '.
	'root.'),
	),
	'line' => array(
	'type' => 'optional int',
	'description' => pht(
	'Line number in the file where the text which triggered the '.
	'message first appears. The first line of the file is line 1, '.
	'not line 0.'),
	),
	'char' => array(
	'type' => 'optional int',
	'description' => pht(
	'Byte position on the line where the text which triggered the '.
	'message starts. The first byte on the line is byte 1, not byte '.
	'0. This position is byte-based (not character-based) because '.
	'not all lintable files have a valid character encoding.'),
	),
	'description' => array(
	'type' => 'optional string',
	'description' => pht(
	'Long explanation of the lint message.'),
	),
	);
	}

	public static function newFromDictionary(
	HarbormasterBuildTarget $build_target,
	array $dict) {

	$obj = self::initializeNewLintMessage($build_target);

	$spec = self::getParameterSpec();
	$spec = ipull($spec, 'type');

	// We're just going to ignore extra keys for now, to make it easier to
	// add stuff here later on.
	$dict = array_select_keys($dict, array_keys($spec));
	PhutilTypeSpec::checkMap($dict, $spec);

	$obj->setPath($dict['path']);
	$obj->setLine(idx($dict, 'line'));
	$obj->setCharacterOffset(idx($dict, 'char'));
	$obj->setCode($dict['code']);
	$obj->setSeverity($dict['severity']);
	$obj->setName($dict['name']);

	$description = idx($dict, 'description');
	if (strlen($description)) {
	$obj->setProperty('description', $description);
	}

	return $obj;
	}

	protected function getConfiguration() {
	return array(
	self::CONFIG_SERIALIZATION => array(
	'properties' => self::SERIALIZATION_JSON,
	),
	self::CONFIG_COLUMN_SCHEMA => array(
	'path' => 'text',
	'line' => 'uint32?',
	'characterOffset' => 'uint32?',
	- 'code' => 'text32',
	+ 'code' => 'text128',
	'severity' => 'text32',
	'name' => 'text255',
	),
	self::CONFIG_KEY_SCHEMA => array(
	'key_target' => array(
	'columns' => array('buildTargetPHID'),
	),
	),
	) + parent::getConfiguration();
	}

	public function attachBuildTarget(HarbormasterBuildTarget $build_target) {
	$this->buildTarget = $build_target;
	return $this;
	}

	public function getBuildTarget() {
	return $this->assertAttached($this->buildTarget);
	}

	public function getProperty($key, $default = null) {
	return idx($this->properties, $key, $default);
	}

	public function setProperty($key, $value) {
	$this->properties[$key] = $value;
	return $this;
	}

	public function getSortKey() {
	// TODO: Maybe use more numeric values after T6861.
	$map = array(
	ArcanistLintSeverity::SEVERITY_ERROR => 'A',
	ArcanistLintSeverity::SEVERITY_WARNING => 'B',
	ArcanistLintSeverity::SEVERITY_AUTOFIX => 'C',
	ArcanistLintSeverity::SEVERITY_ADVICE => 'Y',
	ArcanistLintSeverity::SEVERITY_DISABLED => 'Z',
	);

	$severity = idx($map, $this->getSeverity(), 'N');

	$parts = array(
	$severity,
	$this->getPath(),
	sprintf('%08d', $this->getLine()),
	$this->getCode(),
	);

	return implode("\0", $parts);
	}

	}

File Metadata

Mime Type: text/x-diff
Expires: Sun, Jan 19, 12:31 (3 w, 4 d ago)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 1124597
Default Alt Text: (4 KB)

No OneTemporary
Actions

View Options

File Metadata

Event Timeline

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions