Page MenuHomePhorge
Files F2889685

No OneTemporary
Actions

View Options

diff --git a/src/applications/differential/customfield/DifferentialSummaryField.php b/src/applications/differential/customfield/DifferentialSummaryField.php
index 5052e238e0..a11bebca6e 100644
--- a/src/applications/differential/customfield/DifferentialSummaryField.php
+++ b/src/applications/differential/customfield/DifferentialSummaryField.php
@@ -1,166 +1,82 @@
<?php
final class DifferentialSummaryField
extends DifferentialCoreCustomField {
public function getFieldKey() {
return 'differential:summary';
}
- public function getFieldKeyForConduit() {
- return 'summary';
- }
-
public function getFieldName() {
return pht('Summary');
}
public function getFieldDescription() {
return pht('Stores a summary of the revision.');
}
protected function readValueFromRevision(
DifferentialRevision $revision) {
if (!$revision->getID()) {
return null;
}
return $revision->getSummary();
}
- protected function writeValueToRevision(
- DifferentialRevision $revision,
- $value) {
- $revision->setSummary($value);
- }
-
- public function readValueFromRequest(AphrontRequest $request) {
- $this->setValue($request->getStr($this->getFieldKey()));
- }
-
- public function renderEditControl(array $handles) {
- return id(new PhabricatorRemarkupControl())
- ->setUser($this->getViewer())
- ->setName($this->getFieldKey())
- ->setValue($this->getValue())
- ->setError($this->getFieldError())
- ->setLabel($this->getFieldName());
- }
-
- public function getApplicationTransactionTitle(
- PhabricatorApplicationTransaction $xaction) {
- $author_phid = $xaction->getAuthorPHID();
- $old = $xaction->getOldValue();
- $new = $xaction->getNewValue();
-
- return pht(
- '%s updated the summary for this revision.',
- $xaction->renderHandleLink($author_phid));
- }
-
- public function getApplicationTransactionTitleForFeed(
- PhabricatorApplicationTransaction $xaction) {
-
- $object_phid = $xaction->getObjectPHID();
- $author_phid = $xaction->getAuthorPHID();
- $old = $xaction->getOldValue();
- $new = $xaction->getNewValue();
-
- return pht(
- '%s updated the summary for %s.',
- $xaction->renderHandleLink($author_phid),
- $xaction->renderHandleLink($object_phid));
- }
-
- public function getApplicationTransactionHasChangeDetails(
- PhabricatorApplicationTransaction $xaction) {
- return true;
- }
-
- public function getApplicationTransactionChangeDetails(
- PhabricatorApplicationTransaction $xaction,
- PhabricatorUser $viewer) {
- return $xaction->renderTextCorpusChangeDetails(
- $viewer,
- $xaction->getOldValue(),
- $xaction->getNewValue());
- }
-
- public function shouldHideInApplicationTransactions(
- PhabricatorApplicationTransaction $xaction) {
- return ($xaction->getOldValue() === null);
- }
-
public function shouldAppearInGlobalSearch() {
return true;
}
public function updateAbstractDocument(
PhabricatorSearchAbstractDocument $document) {
if (strlen($this->getValue())) {
$document->addField('body', $this->getValue());
}
}
public function shouldAppearInPropertyView() {
return true;
}
public function renderPropertyViewLabel() {
return $this->getFieldName();
}
public function getStyleForPropertyView() {
return 'block';
}
public function getIconForPropertyView() {
return PHUIPropertyListView::ICON_SUMMARY;
}
public function renderPropertyViewValue(array $handles) {
if (!strlen($this->getValue())) {
return null;
}
return new PHUIRemarkupView($this->getViewer(), $this->getValue());
}
- public function getApplicationTransactionRemarkupBlocks(
- PhabricatorApplicationTransaction $xaction) {
- return array($xaction->getNewValue());
- }
-
- public function shouldAppearInCommitMessage() {
- return true;
- }
-
- public function shouldAppearInCommitMessageTemplate() {
- return true;
- }
-
- public function shouldOverwriteWhenCommitMessageIsEdited() {
- return true;
- }
-
public function shouldAppearInTransactionMail() {
return true;
}
public function updateTransactionMailBody(
PhabricatorMetaMTAMailBody $body,
PhabricatorApplicationTransactionEditor $editor,
array $xactions) {
if (!$editor->getIsNewObject()) {
return;
}
$summary = $this->getValue();
if (!strlen(trim($summary))) {
return;
}
$body->addRemarkupSection(pht('REVISION SUMMARY'), $summary);
}
}

File Metadata

Mime Type
text/x-diff
Expires
Sun, Jan 19, 12:29 (3 w, 4 d ago)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1124586
Default Alt Text
(4 KB)

Event Timeline

Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0