ArcanistDeclarationParenthesesXHPASTLinterRule.php
No OneTemporary
Actions

Size

2 KB

Referenced Files

None

Subscribers

None

ArcanistDeclarationParenthesesXHPASTLinterRule.php
View Options

	<?php

	final class ArcanistDeclarationParenthesesXHPASTLinterRule
	extends ArcanistXHPASTLinterRule {

	const ID = 38;

	public function getLintName() {
	return pht('Declaration Formatting');
	}

	public function getLintSeverity() {
	return ArcanistLintSeverity::SEVERITY_WARNING;
	}

	public function process(XHPASTNode $root) {
	$decs = $root->selectDescendantsOfTypes(array(
	'n_FUNCTION_DECLARATION',
	'n_METHOD_DECLARATION',
	));

	foreach ($decs as $dec) {
	$params = $dec->getChildOfType(3, 'n_DECLARATION_PARAMETER_LIST');
	$tokens = $params->getTokens();

	$first = head($tokens);
	$last = last($tokens);

	$leading = $first->getNonsemanticTokensBefore();
	$leading_text = implode('', mpull($leading, 'getValue'));

	$trailing = $last->getNonsemanticTokensBefore();
	$trailing_text = implode('', mpull($trailing, 'getValue'));

	if ($dec->getChildByIndex(2)->getTypeName() == 'n_EMPTY') {
	// Anonymous functions.
	if ($leading_text != ' ') {
	$this->raiseLintAtOffset(
	$first->getOffset() - strlen($leading_text),
	pht(
	'Convention: space before opening parenthesis in '.
	'anonymous function declarations.'),
	$leading_text,
	' ');
	}
	} else {
	if (preg_match('/^\s+$/', $leading_text)) {
	$this->raiseLintAtOffset(
	$first->getOffset() - strlen($leading_text),
	pht(
	'Convention: no spaces before opening parenthesis in '.
	'function and method declarations.'),
	$leading_text,
	'');
	}
	}

	if (preg_match('/^\s+$/', $trailing_text)) {
	$this->raiseLintAtOffset(
	$last->getOffset() - strlen($trailing_text),
	pht(
	'Convention: no spaces before closing parenthesis in '.
	'function and method declarations.'),
	$trailing_text,
	'');
	}

	$use_list = $dec->getChildByIndex(4);
	if ($use_list->getTypeName() == 'n_EMPTY') {
	continue;
	}
	$use_token = $use_list->selectTokensOfType('T_USE');

	foreach ($use_token as $use) {
	$before = $use->getNonsemanticTokensBefore();
	$after = $use->getNonsemanticTokensAfter();

	if (!$before) {
	$this->raiseLintAtOffset(
	$use->getOffset(),
	pht('Convention: space before `%s` token.', 'use'),
	'',
	' ');
	}

	if (!$after) {
	$this->raiseLintAtOffset(
	$use->getOffset() + strlen($use->getValue()),
	pht('Convention: space after `%s` token.', 'use'),
	'',
	' ');
	}
	}
	}
	}

	}

File Metadata

Mime Type: text/x-php
Expires: Thu, Mar 27, 01:41 (1 w, 3 d ago)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 1236349
Default Alt Text: ArcanistDeclarationParenthesesXHPASTLinterRule.php (2 KB)

ArcanistDeclarationParenthesesXHPASTLinterRule.phpNo OneTemporaryActions

ArcanistDeclarationParenthesesXHPASTLinterRule.phpView Options

File Metadata

Event Timeline

ArcanistDeclarationParenthesesXHPASTLinterRule.php
No OneTemporary
Actions

ArcanistDeclarationParenthesesXHPASTLinterRule.php
View Options