View Options

	diff --git a/src/applications/differential/view/DifferentialRevisionDetailView.php b/src/applications/differential/view/DifferentialRevisionDetailView.php
	index 47d021a033..4093061efb 100644
	--- a/src/applications/differential/view/DifferentialRevisionDetailView.php
	+++ b/src/applications/differential/view/DifferentialRevisionDetailView.php
	@@ -1,171 +1,173 @@
	<?php

	final class DifferentialRevisionDetailView extends AphrontView {

	private $revision;
	private $actions;
	private $auxiliaryFields = array();
	private $diff;
	private $uri;

	public function setURI($uri) {
	$this->uri = $uri;
	return $this;
	}
	public function getURI() {
	return $this->uri;
	}

	public function setDiff(DifferentialDiff $diff) {
	$this->diff = $diff;
	return $this;
	}
	private function getDiff() {
	return $this->diff;
	}

	public function setRevision(DifferentialRevision $revision) {
	$this->revision = $revision;
	return $this;
	}

	public function setActions(array $actions) {
	$this->actions = $actions;
	return $this;
	}
	private function getActions() {
	return $this->actions;
	}

	public function setAuxiliaryFields(array $fields) {
	assert_instances_of($fields, 'DifferentialFieldSpecification');
	$this->auxiliaryFields = $fields;
	return $this;
	}

	public function render() {

	require_celerity_resource('differential-core-view-css');

	$revision = $this->revision;
	$user = $this->getUser();

	$header = $this->renderHeader($revision);

	$actions = id(new PhabricatorActionListView())
	->setUser($user)
	->setObject($revision)
	->setObjectURI($this->getURI());
	foreach ($this->getActions() as $action) {
	$obj = id(new PhabricatorActionView())
	->setIcon(idx($action, 'icon', 'edit'))
	->setName($action['name'])
	->setHref(idx($action, 'href'))
	->setWorkflow(idx($action, 'sigil') == 'workflow')
	->setRenderAsForm(!empty($action['instant']))
	->setUser($user)
	->setDisabled(idx($action, 'disabled', false));
	$actions->addAction($obj);
	}

	$properties = id(new PHUIPropertyListView())
	->setUser($user)
	->setObject($revision);

	$status = $revision->getStatus();
	$local_vcs = $this->getDiff()->getSourceControlSystem();

	$next_step = null;
	if ($status == ArcanistDifferentialRevisionStatus::ACCEPTED) {
	switch ($local_vcs) {
	case PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL:
	$bookmark = $this->getDiff()->getBookmark();
	$next_step = ($bookmark != ''
	? csprintf('arc land %s', $bookmark)
	: 'arc land');
	break;

	case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT:
	$branch = $this->getDiff()->getBranch();
	$next_step = ($branch != ''
	? csprintf('arc land %s', $branch)
	: 'arc land');
	break;

	case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN:
	$next_step = 'arc commit';
	break;
	}
	}
	if ($next_step) {
	$next_step = phutil_tag('tt', array(), $next_step);
	$properties->addProperty(pht('Next Step'), $next_step);
	}

	foreach ($this->auxiliaryFields as $field) {
	$value = $field->renderValueForRevisionView();
	if ($value !== null) {
	$label = rtrim($field->renderLabelForRevisionView(), ':');
	$properties->addProperty($label, $value);
	}
	}
	$properties->setHasKeyboardShortcuts(true);
	$properties->setActionList($actions);

	$properties->invokeWillRenderEvent();

	if (strlen($revision->getSummary())) {
	$properties->addSectionHeader(pht('Summary'));
	$properties->addTextContent(
	PhabricatorMarkupEngine::renderOneObject(
	- id(new PhabricatorMarkupOneOff())->setContent(
	- $revision->getSummary()),
	+ id(new PhabricatorMarkupOneOff())
	+ ->setPreserveLinebreaks(true)
	+ ->setContent($revision->getSummary()),
	'default',
	$user));
	}

	if (strlen($revision->getTestPlan())) {
	$properties->addSectionHeader(pht('Test Plan'));
	$properties->addTextContent(
	PhabricatorMarkupEngine::renderOneObject(
	- id(new PhabricatorMarkupOneOff())->setContent(
	- $revision->getTestPlan()),
	+ id(new PhabricatorMarkupOneOff())
	+ ->setPreserveLinebreaks(true)
	+ ->setContent($revision->getTestPlan()),
	'default',
	$user));
	}

	$object_box = id(new PHUIObjectBoxView())
	->setHeader($header)
	->addPropertyList($properties);

	return $object_box;
	}

	private function renderHeader(DifferentialRevision $revision) {
	$view = id(new PHUIHeaderView())
	->setHeader($revision->getTitle($revision))
	->setUser($this->getUser())
	->setPolicyObject($revision);

	$status = $revision->getStatus();
	$status_name =
	DifferentialRevisionStatus::renderFullDescription($status);

	$view->addProperty(PHUIHeaderView::PROPERTY_STATUS, $status_name);

	return $view;
	}

	public static function renderTagForRevision(
	DifferentialRevision $revision) {

	$status = $revision->getStatus();
	$status_name =
	ArcanistDifferentialRevisionStatus::getNameForRevisionStatus($status);

	return id(new PhabricatorTagView())
	->setType(PhabricatorTagView::TYPE_STATE)
	->setName($status_name);
	}

	}

File Metadata

Mime Type: text/x-diff
Expires: Sun, Jan 19, 17:31 (1 w, 5 d ago)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 1126984
Default Alt Text: (5 KB)

No OneTemporary
Actions

View Options

File Metadata

Event Timeline

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions