diff --git a/resources/celerity/map.php b/resources/celerity/map.php --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -9,8 +9,8 @@ 'names' => array( 'conpherence.pkg.css' => '2f25eb4f', 'conpherence.pkg.js' => '020aebcf', - 'core.pkg.css' => 'ac619266', - 'core.pkg.js' => 'b3c5c317', + 'core.pkg.css' => '112931ab', + 'core.pkg.js' => '820af51e', 'dark-console.pkg.js' => '187792c2', 'differential.pkg.css' => '94bb10ca', 'differential.pkg.js' => '46fcb3af', diff --git a/src/applications/herald/action/HeraldAction.php b/src/applications/herald/action/HeraldAction.php --- a/src/applications/herald/action/HeraldAction.php +++ b/src/applications/herald/action/HeraldAction.php @@ -122,6 +122,9 @@ return $this; } + /* + * @return HeraldAdapter HeraldAdapter class of the action + **/ final public function getAdapter() { return $this->adapter; } diff --git a/src/applications/herald/engine/HeraldEffect.php b/src/applications/herald/engine/HeraldEffect.php --- a/src/applications/herald/engine/HeraldEffect.php +++ b/src/applications/herald/engine/HeraldEffect.php @@ -13,6 +13,9 @@ return $this; } + /** + * @return string PHID of the object that Herald is applied on + */ public function getObjectPHID() { return $this->objectPHID; } @@ -22,6 +25,9 @@ return $this; } + /** + * @return string ACTIONCONST of the HeraldAction + */ public function getAction() { return $this->action; } @@ -31,6 +37,9 @@ return $this; } + /** + * @return array|null + */ public function getTarget() { return $this->target; } @@ -40,6 +49,9 @@ return $this; } + /** + * @return HeraldRule + */ public function getRule() { return $this->rule; } @@ -49,6 +61,10 @@ return $this; } + /** + * @return string Reason why Herald effect was applied, for example + * "Conditions were met for H123 RuleName" + */ public function getReason() { return $this->reason; } diff --git a/src/applications/herald/storage/HeraldRule.php b/src/applications/herald/storage/HeraldRule.php --- a/src/applications/herald/storage/HeraldRule.php +++ b/src/applications/herald/storage/HeraldRule.php @@ -265,6 +265,9 @@ ->addString($this->getName()); } + /** + * @return string Name of the rule, for example "H123 RuleName (Disabled)" + */ public function getEditorDisplayName() { $name = pht('%s %s', $this->getMonogram(), $this->getName());