• adopt window.confirm instead of just confirm to make linter happy

I've proposed a fix for the regression here:

Yes: )

Just to clarify, who are the current administrators of https://github.com/phorgelabs ?

Maybe better now?

Seems good to me. Just small nitpick, the capitalization of words isn't consistent. (ask a new question vs Installation And Setup vs Code contributors manual).

Seems to be gone for now, the only time I get increased lookup times or complete fails is when there's high internet traffic on my own network. Might've just been some of us got unlucky.

Good to know that somebody is monitoring this problem. Feel free to reopen when somebody can share more details

• fix linter

Sorry but this title seems somehow cryptic to me. Are we talking about this feature?

Thank you for this patch. I also agree with @bekay since I'm also concerned about SEO. I tried to apply it.

Thank you @20after4 for this patch. The inline comments seem reasonable to me. What do you think about?

Let me know if you hate the proposed change or you like it.

It's been suggested that simply defaulting all tasks to 1 point solves this issue. However, that raises other issues (for instance, some teams may already be using the Story Points field for actual story-pointing).

By the way I have not understood if you are aware of this situation (I was not):

@MBinder_WMF Does it still describes you goals, or have I distorted it too much?

Uhm. It seems that Phorge/Phabricator does - as default - this thing that 1 point = 1 card.

@Dylsss Are you OK with the small proposed change?

(I said "override" but probably "patch" fits better - since I see that the class is final. I don't know why the codebase is so nazy in having final classes. But I think you can just try to patch it in your local installation. Try!)

OK so you are trying to improve email notifications, immediately showing the Task Priority in the Subject. That's nice honestly.

The added [xxx] lets people easily see right in the email inbox if something needs immediate response without need to open and read the email or login to phorge to check for example the severity or priority of a task. We found that adding such a marker was the easiest way to go. However, if there are better solutions, i am eager to learn about them. Would tags and columns (what are columns in this context?) help there?

Uhm. Yep. Do you know have any idea about what should be changed to achieve this in a secure way?

I wonder if this could be just a patch that assumes Story Points = 1 as sane default instead of zero.

I see that this sender is still as was reported.

I think this could me marked as resolved since lot of users are using Ponder here. Nice.

I mean, is this related to we.phorge.it?

I agree that an agreement could be useful but I don't think that the author should ever allow to re-license its work. I honestly do not want to allow my contributions to be re-licensed, since this usually means that the repository owner wants to re-license that work under a proprietary license when needed. I don't accept that. Normal volunteers do not accept that. This is probably not what we want.

I just want to mark this as resolved since Rector.php is quite nice and simple and we can surely use this tool to do nice things, even without adding it in our Composer but just locally, when we need it.

Untagging Phorge since this is a well-known wide group of issue related to Outlook itself or the SMTP server, and 99.999% not related in any way to Phorge itself.

Out of curiosity, how is it not better to have a column or tag for this?

Superseded by:

try to fix lint again - but I don't hope for it

I understand that this is... too much.

@valerio.bozzolan Thanks for the feedback and sorry for the late response. I must admit that i forgot how we eventually fixed our issue, i only recall it was more about "avoid the issue" and less about "fix the issue". I also completely forgot about this Maniphest. Hence, it is OK for me that it is closed by now. sorry for not taking care about this earlier.

If you are really really really interested in hard-blocking Task creation from custom rules using Herald, it should be probably developed a new Herald Action to support the "block Task creation" if something happens. But I honestly cannot implement this feature, so at the moment I hope the "auto-comment" is enough for you.