@Matthew the arcanist herald rule needs to be set to trigger when both conditions are met - currently even if a change is accepted only a member of Releasers can land the change because it will trigger for anyone who isn’t a member of Releasers. We want it to trigger if it both hasn’t been reviewed and the user isn’t a member of Releasers.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Oct 29 2022
For completeness: The security breaches mentioned in the security guidance task are all about exposing an existing file that the attacker has new view access to; This flow is only relevant to explicitly uploading a new file, so it doesn't have the same security implications.
Oct 28 2022
The change should also include updating the installation instructions, and a ticket.
https://secure.phabricator.com/T9782 suggests it should be using the "custom fields" interface and eventually fizzles out.
Rebased and run unit tests again
(On a broader theme, this code should probably move into rP, right? Is there any use-case for arcanist directly making calls to 3rd party services?)
running celerity map should just fix it. I'll take a look.
I'm good with this, but we have a policy of "no landed diffs w/o tickets", so please create one before landing.
We should connect this script (scripts/celerity/*.php) into bin/celerity.
Oct 26 2022
Oct 25 2022
Oct 24 2022
Oct 23 2022
In T15105#3252, @tiguchi wrote:In T15105#3239, @Matthew wrote:In T15105#3233, @tiguchi wrote:As a bandaid I patched the extractFilePHIDs method in PholioImageFileTransaction.php by adding a nested foreach loop as follows:
foreach ($new_phids as $phids) { foreach ($phids as $phid) { $file_phids[] = $editor->loadPholioImage($object, $phid) ->getFilePHID(); } }This fixes the problem on our installation for now, but I would like to avoid having to manage any local changes
Would you be willing to create a revision so we can put that fix into upstream? If you're not sure how, or need some help, feel free to ping me!
I just submitted a patch and ran into issues with running unit tests. It seems like the tests expect me to set up a MySQL database. I submitted the patch with arc diff --nounit if that's OK with you
Oct 22 2022
Oct 21 2022
The harbormaster has passed and you have properly fixed the bug.
In T15105#3239, @Matthew wrote:In T15105#3233, @tiguchi wrote:As a bandaid I patched the extractFilePHIDs method in PholioImageFileTransaction.php by adding a nested foreach loop as follows:
foreach ($new_phids as $phids) { foreach ($phids as $phid) { $file_phids[] = $editor->loadPholioImage($object, $phid) ->getFilePHID(); } }This fixes the problem on our installation for now, but I would like to avoid having to manage any local changes
Would you be willing to create a revision so we can put that fix into upstream? If you're not sure how, or need some help, feel free to ping me!
Oct 19 2022
Oct 18 2022
Did we ever find out more about the hosting situation for phorge.it?
If the users want to use milestones instead of subprojects, can they not change the language settings to Pirate English or something and go from there?
In T15105#3233, @tiguchi wrote:As a bandaid I patched the extractFilePHIDs method in PholioImageFileTransaction.php by adding a nested foreach loop as follows:
foreach ($new_phids as $phids) { foreach ($phids as $phid) { $file_phids[] = $editor->loadPholioImage($object, $phid) ->getFilePHID(); } }This fixes the problem on our installation for now, but I would like to avoid having to manage any local changes
Oct 16 2022
In addition to the above, it seems that commit d017f3f21021 is what broke this. And adjustTransactionValues is what changes the xaction from
Array ( [+] => Array ( [0] => PHID-PIMG-m5pqg3eec46uvzw6uynm )
Oct 15 2022
Small update: I just migrated our Phabricator installation to Phorge following the instructions in Update From Phabricator. The migration worked, but we still cannot upload new mockups.
Oct 14 2022
Oct 13 2022
Can we make a draft of this document and then publish it once done?
In D25052#1750, @avivey wrote:I'd expect some PHP code to actually attach the files from attachedFilePHIDs to the relevant object, but I don't see it in this diff. Is that already happening somehow?
Hi - thanks for your response; but I was looking for support/consultancy for the upgrade - is anyone able to offer this?
Oct 12 2022
Working around this right now by setting up a Relayed Domain on my mail server and pointing it to the server that my Phorge instance is running on. Obviously only an option if you are running your mailserver, and your configuration isn't too complex to support it.
Oct 11 2022
ok, done. But I don't know how to fix the unit tests. after running celerity map command what should I do ?
I changed everything branded Phabricator in th 10k files in my fork to Phorge and applied this change to filenames.
Another example of broken dark theme
i can see a few mentions of Phabricator on the documentation, i am not sure if its because the documentation was left out, or because there are some elments in the codebase that still mention phabricator.
where is the standard installation documentation for phorge, i only see migration
There's a difference between deleting data as a Phab/Phorge admin (which is done via the bin/delete script, and prints out a massive warning about it potentially breaking stuff and generally being a bad idea), and schema migrations done as part of an upgrade, which would happily delete data without a second thought.
Oct 10 2022
In T15126#3165, @Cigaryno wrote:In T15126#3158, @avivey wrote:can we keep the actual deletion as optional for a very long time/forever, and at the same time not create the database for new installs?
that will allow installs to backup/export their logs even if they miss the deprecation warning.No, we should basically follow the two parts per @Matthew.
Oct 9 2022
Also, this is fairly similar to T15082. Having Epics would probably also resolve that.
I feel like the idea behind milestones being strictly ordered is from the viewpoint that milestones are sequential "events" that happen in development one after another in a given order.