Page MenuHomePhorge
Feed All Stories

Oct 29 2022

MacFan4000 added a comment to T15115: Herald rule changes for release.

@Matthew the arcanist herald rule needs to be set to trigger when both conditions are met - currently even if a change is accepted only a member of Releasers can land the change because it will trigger for anyone who isn’t a member of Releasers. We want it to trigger if it both hasn’t been reviewed and the user isn’t a member of Releasers.

Oct 29 2022, 19:04 · phorge.it install
Cigaryno added a project to T15106: "Upload file" in remarkup text fields should attach by default : Remarkup.
Oct 29 2022, 11:08 · Files, Remarkup
Cigaryno added a project to T15128: Allow users to change the default edit policy of revisions: Policy (archived).
Oct 29 2022, 11:06 · Policy, Differential, User-Cigaryno
Cigaryno edited the content of Change Log.
Oct 29 2022, 10:10
Cigaryno renamed 2022 Week 43 from 2022 Week 42 to 2022 Week 43.
Oct 29 2022, 10:09
Cigaryno edited the content of 2022 Week 42.
Oct 29 2022, 08:27
avivey added a comment to T15106: "Upload file" in remarkup text fields should attach by default .

For completeness: The security breaches mentioned in the security guidance task are all about exposing an existing file that the attacker has new view access to; This flow is only relevant to explicitly uploading a new file, so it doesn't have the same security implications.

Oct 29 2022, 07:07 · Files, Remarkup

Oct 28 2022

MacFan4000 removed a reviewer for D25055: Update sprite sheets: Cigaryno.
Oct 28 2022, 15:35 · Auth (archived)
avivey added a comment to D25054: Replace PHPExcel with PhpSpreadsheet.

The change should also include updating the installation instructions, and a ticket.

Oct 28 2022, 10:55
avivey accepted D25057: updating twitch to latest api (Helix).
Oct 28 2022, 10:53 · Auth (archived)
avivey added a comment to T15133: Differential List View should show Repository.

https://secure.phabricator.com/T9782 suggests it should be using the "custom fields" interface and eventually fizzles out.

Oct 28 2022, 10:48 · Differential
avivey updated the diff for D25057: updating twitch to latest api (Helix).

Rebased and run unit tests again

Oct 28 2022, 10:43 · Auth (archived)
avivey accepted D25056: updating twitch to latest api (Helix).

(On a broader theme, this code should probably move into rP, right? Is there any use-case for arcanist directly making calls to 3rd party services?)

Oct 28 2022, 10:34 · Auth (archived)
avivey added a comment to T15122: Twitch auth provider is not working - old twitch API has been decomissioned.

running celerity map should just fix it. I'll take a look.

Oct 28 2022, 10:32
avivey created T15133: Differential List View should show Repository.
Oct 28 2022, 10:31 · Differential
avivey accepted D25037: Hide the "hidden" fields on custom form previews.

I'm good with this, but we have a policy of "no landed diffs w/o tickets", so please create one before landing.

Oct 28 2022, 10:28
avivey accepted D25055: Update sprite sheets.

We should connect this script (scripts/celerity/*.php) into bin/celerity.

Oct 28 2022, 10:26 · Auth (archived)
kwisatz awarded T15078: Support for hardware keys as second factor a Like token.
Oct 28 2022, 10:21 · Auth
avivey accepted D25052: Add and use new RemarkupMetadata class.
Oct 28 2022, 10:19 · Remarkup
Cigaryno created Policy (archived).
Oct 28 2022, 08:43
avivey added a member for Trusted Contributors: cristian64.
Oct 28 2022, 07:49
avivey created T15132: Support monospaced links in remarkup.
Oct 28 2022, 07:48 · Remarkup
avivey created Remarkup.
Oct 28 2022, 07:38

Oct 26 2022

Ekubischta added Q20: After uploading an image to a task, rights are not inherited. Image in status Restricted (Answer 15).
Oct 26 2022, 21:35

Oct 25 2022

Cigaryno changed the visibility for Q19: Are there plans to switch from PHPExcel to PHPSpreadsheet for Maniphest task export.
Oct 25 2022, 18:38
Rexogamer awarded T15056: Improve Dark Mode a Love token.
Oct 25 2022, 11:18 · User-Cigaryno, User-valerio.bozzolan, Accessibility, User-Bukkit
kretov.d attached a referenced file: F190984: image (3).png.
Oct 25 2022, 08:28
kretov.d asked Q20: After uploading an image to a task, rights are not inherited. Image in status Restricted.
Oct 25 2022, 07:36

Oct 24 2022

MauMoJo asked Q19: Are there plans to switch from PHPExcel to PHPSpreadsheet for Maniphest task export.
Oct 24 2022, 07:56

Oct 23 2022

Matthew added a comment to T15105: Cannot upload new mockups via Pholio.

As a bandaid I patched the extractFilePHIDs method in PholioImageFileTransaction.php by adding a nested foreach loop as follows:

foreach ($new_phids as $phids) {
  foreach ($phids as $phid) {
    $file_phids[] = $editor->loadPholioImage($object, $phid)
      ->getFilePHID();
  }
}

This fixes the problem on our installation for now, but I would like to avoid having to manage any local changes

Would you be willing to create a revision so we can put that fix into upstream? If you're not sure how, or need some help, feel free to ping me!

I just submitted a patch and ran into issues with running unit tests. It seems like the tests expect me to set up a MySQL database. I submitted the patch with arc diff --nounit if that's OK with you

Oct 23 2022, 16:59 · phorge.it install (DEPRECATED)

Oct 22 2022

Cigaryno edited the content of 2022 Week 42.
Oct 22 2022, 09:23
Cigaryno edited the content of Change Log.
Oct 22 2022, 09:20

Oct 21 2022

Cigaryno edited projects for T15131: Add Workboards support for Differential, added: Projects (archived); removed Maniphest (archived).
Oct 21 2022, 16:27 · Clarification Needed, Differential, Workboard, User-Cigaryno
Cigaryno created T15131: Add Workboards support for Differential.
Oct 21 2022, 16:01 · Clarification Needed, Differential, Workboard, User-Cigaryno
Cigaryno added a project to D25058: Fix broken file PHID extraction that causes Pholio uploads to crash: Pholio.
Oct 21 2022, 15:55 · Pholio
Cigaryno renamed T15079: Upstream translatewiki.net's changes from Upstream TranslateWiki's changes to Upstream translatewiki.net's changes.
Oct 21 2022, 15:43 · Localization
Cigaryno accepted D25058: Fix broken file PHID extraction that causes Pholio uploads to crash.

The harbormaster has passed and you have properly fixed the bug.

NOTE: This revision is not ready to land because I am not a member of Blessed Committers. It will be ready to land once accepted by members of Blessed Committers.
Oct 21 2022, 15:35 · Pholio
tiguchi added a comment to T15105: Cannot upload new mockups via Pholio.

As a bandaid I patched the extractFilePHIDs method in PholioImageFileTransaction.php by adding a nested foreach loop as follows:

foreach ($new_phids as $phids) {
  foreach ($phids as $phid) {
    $file_phids[] = $editor->loadPholioImage($object, $phid)
      ->getFilePHID();
  }
}

This fixes the problem on our installation for now, but I would like to avoid having to manage any local changes

Would you be willing to create a revision so we can put that fix into upstream? If you're not sure how, or need some help, feel free to ping me!

Oct 21 2022, 15:11 · phorge.it install (DEPRECATED)
tiguchi requested review of D25058: Fix broken file PHID extraction that causes Pholio uploads to crash.
Oct 21 2022, 15:09 · Pholio
tiguchi added a revision to T15105: Cannot upload new mockups via Pholio: D25058: Fix broken file PHID extraction that causes Pholio uploads to crash.
Oct 21 2022, 15:09 · phorge.it install (DEPRECATED)

Oct 19 2022

Cigaryno renamed 2022 Week 42 from 2022 Week 41 to 2022 Week 42.
Oct 19 2022, 18:09
Cigaryno renamed T15118: User icon may overlap in the user menu if no real name is set from User icon may overlap in the user manu if no real name is set to User icon may overlap in the user menu if no real name is set.
Oct 19 2022, 16:48 · People, Bug Reports, User-Cigaryno

Oct 18 2022

dcog added a comment to T15030: Support a Phorge Extensions ecosystem.

Did we ever find out more about the hosting situation for phorge.it?

Oct 18 2022, 19:40 · Extension Development, Phactory: Community Projects, Phorge
Matthew created an object: 2022-10-18.
Oct 18 2022, 19:39
dcog added a comment to T15127: Allow for reordering of milestones.

If the users want to use milestones instead of subprojects, can they not change the language settings to Pirate English or something and go from there?

Oct 18 2022, 19:38 · Workboard
Matthew added a comment to T15105: Cannot upload new mockups via Pholio.

As a bandaid I patched the extractFilePHIDs method in PholioImageFileTransaction.php by adding a nested foreach loop as follows:

foreach ($new_phids as $phids) {
  foreach ($phids as $phid) {
    $file_phids[] = $editor->loadPholioImage($object, $phid)
      ->getFilePHID();
  }
}

This fixes the problem on our installation for now, but I would like to avoid having to manage any local changes

Oct 18 2022, 19:32 · phorge.it install (DEPRECATED)
Matthew edited the content of Planning Meetings.
Oct 18 2022, 19:19 · phorge.it install

Oct 16 2022

MacFan4000 added Q18: Lowest and Highest supported PHP (Answer 14).
Oct 16 2022, 21:57
Dylsss added a comment to T15105: Cannot upload new mockups via Pholio.

In addition to the above, it seems that commit d017f3f21021 is what broke this. And adjustTransactionValues is what changes the xaction from

Array
(
    [+] => Array
        (
            [0] => PHID-PIMG-m5pqg3eec46uvzw6uynm
        )
Oct 16 2022, 15:32 · phorge.it install (DEPRECATED)

Oct 15 2022

tiguchi added a comment to T15105: Cannot upload new mockups via Pholio.

Small update: I just migrated our Phabricator installation to Phorge following the instructions in Update From Phabricator. The migration worked, but we still cannot upload new mockups.

Oct 15 2022, 17:27 · phorge.it install (DEPRECATED)
Cigaryno renamed T15064: Make Phorge compatible with PHP 8.1/8.2/8.3 from Make phorge compatible with PHP 8.1 to Make Phorge compatible with PHP 8.1.
Oct 15 2022, 08:08 · PHP 8 support
Cigaryno added a member for Maniphest (archived): Cigaryno.
Oct 15 2022, 08:02
Cigaryno created T15130: Organize Projects here.
Oct 15 2022, 07:58 · phorge.it install, User-Cigaryno

Oct 14 2022

Cigaryno edited the content of Installation And Setup.
Oct 14 2022, 17:20
Cigaryno edited the content of IRC Channel.
Oct 14 2022, 07:00
Cigaryno edited the content of Welcome.
Oct 14 2022, 06:59 · Phorge

Oct 13 2022

Cigaryno added a comment to Starmap.

Can we make a draft of this document and then publish it once done?

Oct 13 2022, 18:25
Cigaryno added a member for Trusted Contributors: Dylsss.
Oct 13 2022, 16:03
Dylsss added a comment to D25052: Add and use new RemarkupMetadata class.
In D25052#1750, @avivey wrote:

I'd expect some PHP code to actually attach the files from attachedFilePHIDs to the relevant object, but I don't see it in this diff. Is that already happening somehow?

It's done here: https://we.phorge.it/source/phorge/browse/master/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php;5aa159a83013fca3a72f5c6d2c493c117fbbf83b$2296

Oct 13 2022, 14:11 · Remarkup
MCPCN added a comment to Q17: Support for migrations from Phabricator (Answer 12).

Hi - thanks for your response; but I was looking for support/consultancy for the upgrade - is anyone able to offer this?

Oct 13 2022, 10:18

Oct 12 2022

Cigaryno edited the content of Welcome.
Oct 12 2022, 17:23 · Phorge
Cigaryno updated Cigaryno.
Oct 12 2022, 17:16
golyalpha added a comment to T15086: Support Inbound Mail over IMAP.

Working around this right now by setting up a Relayed Domain on my mail server and pointing it to the server that my Phorge instance is running on. Obviously only an option if you are running your mailserver, and your configuration isn't too complex to support it.

Oct 12 2022, 05:58 · Mail

Oct 11 2022

k__nard added a comment to T15122: Twitch auth provider is not working - old twitch API has been decomissioned.

ok, done. But I don't know how to fix the unit tests. after running celerity map command what should I do ?

Oct 11 2022, 19:41
k__nard added a task to D25057: updating twitch to latest api (Helix): T15122: Twitch auth provider is not working - old twitch API has been decomissioned.
Oct 11 2022, 19:40 · Auth (archived)
k__nard added a revision to T15122: Twitch auth provider is not working - old twitch API has been decomissioned: D25057: updating twitch to latest api (Helix).
Oct 11 2022, 19:40
k__nard added a project to D25057: updating twitch to latest api (Helix): Auth (archived).
Oct 11 2022, 19:39 · Auth (archived)
k__nard requested review of D25057: updating twitch to latest api (Helix).
Oct 11 2022, 19:35 · Auth (archived)
Cigaryno edited the content of Installation And Setup.
Oct 11 2022, 18:39
Cigaryno added a comment to T15006: Re-brand Phorge.

I changed everything branded Phabricator in th 10k files in my fork to Phorge and applied this change to filenames.

Oct 11 2022, 18:15 · Phorge
golyalpha added a comment to T15056: Improve Dark Mode.

Another example of broken dark theme

Oct 11 2022, 17:51 · User-Cigaryno, User-valerio.bozzolan, Accessibility, User-Bukkit
golyalpha updated the answer details for Q18: Lowest and Highest supported PHP (Answer 13).
Oct 11 2022, 17:49
golyalpha added Q18: Lowest and Highest supported PHP (Answer 13).
Oct 11 2022, 17:49
oneitonitram asked Q18: Lowest and Highest supported PHP.
Oct 11 2022, 13:51
MacFan4000 added a comment to Installation And Setup.

https://we.phorge.it/book/phorge/article/installation_guide/

Oct 11 2022, 13:31
oneitonitram added a comment to T15006: Re-brand Phorge.

i can see a few mentions of Phabricator on the documentation, i am not sure if its because the documentation was left out, or because there are some elments in the codebase that still mention phabricator.

Oct 11 2022, 12:38 · Phorge
oneitonitram added a comment to Installation And Setup.

where is the standard installation documentation for phorge, i only see migration

Oct 11 2022, 12:26
golyalpha added a comment to T15126: Remove Chatlog.

There's a difference between deleting data as a Phab/Phorge admin (which is done via the bin/delete script, and prints out a massive warning about it potentially breaking stuff and generally being a bad idea), and schema migrations done as part of an upgrade, which would happily delete data without a second thought.

Oct 11 2022, 12:08 · Conpherence, User-Cigaryno, Chatlog

Oct 10 2022

bubble0h7 updated bubble0h7.
Oct 10 2022, 21:41
Nibbly added a comment to T15126: Remove Chatlog.
In T15126#3158, @avivey wrote:

can we keep the actual deletion as optional for a very long time/forever, and at the same time not create the database for new installs?
that will allow installs to backup/export their logs even if they miss the deprecation warning.

No, we should basically follow the two parts per @Matthew.

Oct 10 2022, 15:06 · Conpherence, User-Cigaryno, Chatlog

Oct 9 2022

k__nard added a project to D25056: updating twitch to latest api (Helix): Auth (archived).
Oct 9 2022, 18:36 · Auth (archived)
k__nard added a revision to T15122: Twitch auth provider is not working - old twitch API has been decomissioned: D25056: updating twitch to latest api (Helix).
Oct 9 2022, 18:35
k__nard added a task to D25056: updating twitch to latest api (Helix): T15122: Twitch auth provider is not working - old twitch API has been decomissioned.
Oct 9 2022, 18:35 · Auth (archived)
k__nard requested review of D25056: updating twitch to latest api (Helix).
Oct 9 2022, 18:28 · Auth (archived)
Cigaryno created T15129: Unmark Audit as a required application.
Oct 9 2022, 18:09 · Diffusion, User-Cigaryno
Cigaryno edited the content of Object Name Prefixes / Monograms.
Oct 9 2022, 17:58
golyalpha added a comment to T15127: Allow for reordering of milestones.

Also, this is fairly similar to T15082. Having Epics would probably also resolve that.

Oct 9 2022, 10:31 · Workboard
avivey closed D25032: Update PassphraseCredential to support Mentions.
Oct 9 2022, 10:30
avivey committed rP4aedc206c727: Update PassphraseCredential to support Mentions (authored by Ekubischta).
Update PassphraseCredential to support Mentions
Oct 9 2022, 10:30
avivey closed D25021: Added cross-platform default fonts.
Oct 9 2022, 10:30
avivey closed T15049: Segoe UI Symbol provides bad user experience as Resolved by committing rPf8ffa393c442: Added cross-platform default fonts.
Oct 9 2022, 10:30 · Fonts
avivey committed rPf8ffa393c442: Added cross-platform default fonts (authored by vedranmiletic).
Added cross-platform default fonts
Oct 9 2022, 10:30
avivey changed the visibility for Security.
Oct 9 2022, 10:20
golyalpha added a comment to T15127: Allow for reordering of milestones.

I feel like the idea behind milestones being strictly ordered is from the viewpoint that milestones are sequential "events" that happen in development one after another in a given order.

Oct 9 2022, 10:18 · Workboard
avivey accepted D25021: Added cross-platform default fonts.
Oct 9 2022, 10:16
avivey created an object: 2022-10-04.
Oct 9 2022, 10:04

Oct 7 2022

jeremy.norris added a watcher for Governance: jeremy.norris.
Oct 7 2022, 14:19
jeremy.norris added a watcher for Security: jeremy.norris.
Oct 7 2022, 14:18
Cigaryno added a watcher for Security: Cigaryno.
Oct 7 2022, 07:11
Cigaryno created T15128: Allow users to change the default edit policy of revisions.
Oct 7 2022, 07:10 · Policy, Differential, User-Cigaryno