Page MenuHomePhorge
Feed Advanced Search

Mar 27 2023

valerio.bozzolan edited the content of 2023 Week 2.
Mar 27 2023, 05:14
valerio.bozzolan closed T15201: PHP 8.2: creation of dynamic property is deprecated, a subtask of T15198: PHP 8.2 deprecations fix strategies, as Resolved.
Mar 27 2023, 05:10 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan closed T15201: PHP 8.2: creation of dynamic property is deprecated as Resolved by committing rPd98c47041f13: PHP 8.2: fix deprecated creation of dynamic properties.
Mar 27 2023, 05:10 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan closed D25100: PHP 8.2: fix deprecated creation of dynamic properties.
Mar 27 2023, 05:10
valerio.bozzolan committed rPd98c47041f13: PHP 8.2: fix deprecated creation of dynamic properties.
PHP 8.2: fix deprecated creation of dynamic properties
Mar 27 2023, 05:10
valerio.bozzolan updated the diff for D25100: PHP 8.2: fix deprecated creation of dynamic properties.

checkout master and cherry-pick from D25100

Mar 27 2023, 05:09

Mar 26 2023

valerio.bozzolan added a comment to T15053: Develop the translation strategy for strings on the client `JX` side.

I think that, from the view model, we should be able to call something like this:

Mar 26 2023, 21:04
valerio.bozzolan added a parent task for T15053: Develop the translation strategy for strings on the client `JX` side: T15168: Improve JavaScript i18n.
Mar 26 2023, 20:57
valerio.bozzolan added a subtask for T15168: Improve JavaScript i18n: T15053: Develop the translation strategy for strings on the client `JX` side.
Mar 26 2023, 20:57 · User-valerio.bozzolan, Localization
valerio.bozzolan added a revision to T15034: Show confirmation dialog when closing a modal if form contents have been changed: D25015: Show confirmation dialog when closing a modal if form contents have been changed.
Mar 26 2023, 20:52 · Maniphest, UX
valerio.bozzolan added a task to D25015: Show confirmation dialog when closing a modal if form contents have been changed: T15034: Show confirmation dialog when closing a modal if form contents have been changed.
Mar 26 2023, 20:52 · Maniphest (archived)
valerio.bozzolan triaged T15202: Show confirmation dialog also when closing tab if content changed as Wishlist priority.
Mar 26 2023, 20:49 · Maniphest, User-valerio.bozzolan, UX
valerio.bozzolan added a comment to D25098: PHP 8.2: fixes for deprecated use of ${var} in strings.

Thanks @avivey honestly it was interesting and deeply connected to a scary PHP internal travel: if I understand correctly, "id" is considered a constant and expanded as the "id" string for backward compatibility reasons. Then, ${} expands that.

Mar 26 2023, 20:33
valerio.bozzolan updated the summary of D25100: PHP 8.2: fix deprecated creation of dynamic properties.
Mar 26 2023, 20:27
valerio.bozzolan edited Description on UX.
Mar 26 2023, 20:25
valerio.bozzolan added a project to T15172: Drag & Drop: avoid to lose Edits when clicking on the Success popup: UX.
Mar 26 2023, 20:24 · Files, User-valerio.bozzolan, UX
valerio.bozzolan added a project to T15034: Show confirmation dialog when closing a modal if form contents have been changed: UX.
Mar 26 2023, 20:24 · Maniphest, UX
valerio.bozzolan edited the content of 2023 Week 2.
Mar 26 2023, 20:24
valerio.bozzolan created UX.
Mar 26 2023, 20:23
valerio.bozzolan edited the content of 2023 Week 2.
Mar 26 2023, 20:22
valerio.bozzolan created Typehead.
Mar 26 2023, 20:20
valerio.bozzolan edited the content of 2023 Week 2.
Mar 26 2023, 20:17
valerio.bozzolan added a project to T15049: Segoe UI Symbol provides bad user experience: Fonts.
Mar 26 2023, 20:17 · Fonts
valerio.bozzolan created Fonts.
Mar 26 2023, 20:16
valerio.bozzolan added inline comments to rPaadc1b7bf024: Add PHIDType for HeraldTransaction.
Mar 26 2023, 20:13
valerio.bozzolan added inline comments to rP43f9927a38f7: Compare two branches.
Mar 26 2023, 20:12
valerio.bozzolan closed T15196: PHP 8.2: using ${var} in strings is deprecated, a subtask of T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo), as Resolved.
Mar 26 2023, 20:09 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan closed T15196: PHP 8.2: using ${var} in strings is deprecated, a subtask of T15198: PHP 8.2 deprecations fix strategies, as Resolved.
Mar 26 2023, 20:09 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan closed T15196: PHP 8.2: using ${var} in strings is deprecated as Resolved.

Wow. Probably there was only one case. Let's stay ready to reopen, but probably we are OK.

Mar 26 2023, 20:09 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan closed D25098: PHP 8.2: fixes for deprecated use of ${var} in strings.
Mar 26 2023, 20:08
valerio.bozzolan committed rP03c9bf575e43: PHP 8.2: fixes for deprecated use of ${var} in strings.
PHP 8.2: fixes for deprecated use of ${var} in strings
Mar 26 2023, 20:08
valerio.bozzolan awarded D25098: PHP 8.2: fixes for deprecated use of ${var} in strings a Like token.
Mar 26 2023, 20:07
valerio.bozzolan updated the test plan for D25099: PHP 8.2: fix deprecated use of "parent" in callables.
Mar 26 2023, 18:06
valerio.bozzolan updated the summary of D25084: Remarkup: avoid to open internal pages as external links (as default).
Mar 26 2023, 16:56
valerio.bozzolan updated the task description for T15200: PHP 8.2: Use of "parent" in callables is deprecated.
Mar 26 2023, 16:55 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan removed a revision from T15200: PHP 8.2: Use of "parent" in callables is deprecated: D25100: PHP 8.2: fix deprecated creation of dynamic properties.
Mar 26 2023, 16:54 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan removed a task from D25100: PHP 8.2: fix deprecated creation of dynamic properties: T15200: PHP 8.2: Use of "parent" in callables is deprecated.
Mar 26 2023, 16:54
valerio.bozzolan requested review of D25100: PHP 8.2: fix deprecated creation of dynamic properties.
Mar 26 2023, 16:49
valerio.bozzolan added a revision to T15200: PHP 8.2: Use of "parent" in callables is deprecated: D25100: PHP 8.2: fix deprecated creation of dynamic properties.
Mar 26 2023, 16:49 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan added a revision to T15201: PHP 8.2: creation of dynamic property is deprecated: D25100: PHP 8.2: fix deprecated creation of dynamic properties.
Mar 26 2023, 16:49 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan updated the task description for T15201: PHP 8.2: creation of dynamic property is deprecated.
Mar 26 2023, 16:47 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan raised a concern with rPb8a515cb29d8: Bring new password validation into AuthPasswordEngine.
Mar 26 2023, 16:27
valerio.bozzolan triaged T15201: PHP 8.2: creation of dynamic property is deprecated as High priority.
Mar 26 2023, 16:25 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan updated the test plan for D25099: PHP 8.2: fix deprecated use of "parent" in callables.
Mar 26 2023, 16:06
valerio.bozzolan added inline comments to D25099: PHP 8.2: fix deprecated use of "parent" in callables.
Mar 26 2023, 15:57
valerio.bozzolan updated the test plan for D25099: PHP 8.2: fix deprecated use of "parent" in callables.
Mar 26 2023, 15:51
valerio.bozzolan requested review of D25099: PHP 8.2: fix deprecated use of "parent" in callables.
Mar 26 2023, 15:42
valerio.bozzolan added a revision to T15200: PHP 8.2: Use of "parent" in callables is deprecated: D25099: PHP 8.2: fix deprecated use of "parent" in callables.
Mar 26 2023, 15:42 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan moved T15064: Make Phorge compatible with PHP 8.1/8.2/8.3 from Backlog to Epic on the PHP 8.2 support board.
Mar 26 2023, 15:22 · PHP 8 support
valerio.bozzolan moved T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo) from Backlog to Epic on the PHP 8.2 support board.
Mar 26 2023, 15:22 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan renamed T15198: PHP 8.2 deprecations fix strategies from Handle deprecations of PHP 8.2 to PHP 8.2 deprecations fix strategies.
Mar 26 2023, 15:22 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan updated the task description for T15200: PHP 8.2: Use of "parent" in callables is deprecated.
Mar 26 2023, 15:15 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan retitled D25031: Fix most PHP 8.1 and 8.2 issues from Fix most PHP 8.1 issues
Mar 26 2023, 15:09 · Phorge
valerio.bozzolan added a task to D25031: Fix most PHP 8.1 and 8.2 issues: T15198: PHP 8.2 deprecations fix strategies.
Mar 26 2023, 15:09 · Phorge
valerio.bozzolan added a task to D25030: Fix PHP 8.1 and 8.2 incompatibilities mostly: T15198: PHP 8.2 deprecations fix strategies.
Mar 26 2023, 15:09 · Arcanist (archived)
valerio.bozzolan added revisions to T15198: PHP 8.2 deprecations fix strategies: D25030: Fix PHP 8.1 and 8.2 incompatibilities mostly, D25031: Fix most PHP 8.1 and 8.2 issues.
Mar 26 2023, 15:09 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan retitled D25030: Fix PHP 8.1 and 8.2 incompatibilities mostly from Fix PHP 8.1 incompatibilities mostly
Mar 26 2023, 15:08 · Arcanist (archived)
valerio.bozzolan claimed T15196: PHP 8.2: using ${var} in strings is deprecated.
Mar 26 2023, 15:05 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

I added that sub-task since it is a bit hypocritical for us to ask why many people don't use Arcanist... if Arcanist does not support any official stable version of PHP.

Mar 26 2023, 15:02 · Discussion Needed, Arcanist
valerio.bozzolan added a comment to T15196: PHP 8.2: using ${var} in strings is deprecated.
Mar 26 2023, 15:01 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan added a parent task for T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo): T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..
Mar 26 2023, 15:00 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan added a subtask for T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues.: T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo).
Mar 26 2023, 15:00 · Discussion Needed, Arcanist
valerio.bozzolan requested review of D25098: PHP 8.2: fixes for deprecated use of ${var} in strings.
Mar 26 2023, 14:42
valerio.bozzolan added a revision to T15196: PHP 8.2: using ${var} in strings is deprecated: D25098: PHP 8.2: fixes for deprecated use of ${var} in strings.
Mar 26 2023, 14:42 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan added a comment to T15196: PHP 8.2: using ${var} in strings is deprecated.

It seems Rector.php has not an automatic rule for that.

Mar 26 2023, 14:40 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan added inline comments to D25097: PHP 8.2: fixes for strlen() not accepting NULL anymore.
Mar 26 2023, 14:35
valerio.bozzolan added inline comments to D25097: PHP 8.2: fixes for strlen() not accepting NULL anymore.
Mar 26 2023, 14:34
valerio.bozzolan updated the diff for D25097: PHP 8.2: fixes for strlen() not accepting NULL anymore.

simplify even more

Mar 26 2023, 14:31
valerio.bozzolan updated the diff for D25097: PHP 8.2: fixes for strlen() not accepting NULL anymore.

try to make the diff even more simple

Mar 26 2023, 14:28
valerio.bozzolan added a revision to T15199: Introduce PhabricatorEnv::getEnvConfigStr() - that always return a string: D25097: PHP 8.2: fixes for strlen() not accepting NULL anymore.
Mar 26 2023, 14:25 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan updated the summary of D25097: PHP 8.2: fixes for strlen() not accepting NULL anymore.
Mar 26 2023, 14:25
valerio.bozzolan added a comment to T15199: Introduce PhabricatorEnv::getEnvConfigStr() - that always return a string.

I renamed the proposal from configString() to configStr() so that I do not break the 80 characters lint limitation ihih

Mar 26 2023, 14:25 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan added a comment to D25031: Fix most PHP 8.1 and 8.2 issues.

This revision is nearly impossible to test

See my comments here D25030#1893

Error suppression with "@" is a poor solution to this issue

Mar 26 2023, 14:24 · Phorge
valerio.bozzolan updated the summary of D25097: PHP 8.2: fixes for strlen() not accepting NULL anymore.
Mar 26 2023, 14:23
valerio.bozzolan added inline comments to D25097: PHP 8.2: fixes for strlen() not accepting NULL anymore.
Mar 26 2023, 14:20
valerio.bozzolan updated the diff for D25097: PHP 8.2: fixes for strlen() not accepting NULL anymore.

use PHP 7.4 to make lint happy

Mar 26 2023, 14:15
valerio.bozzolan requested review of D25097: PHP 8.2: fixes for strlen() not accepting NULL anymore.
Mar 26 2023, 14:14
valerio.bozzolan added a revision to T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies: D25097: PHP 8.2: fixes for strlen() not accepting NULL anymore.
Mar 26 2023, 14:14 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan renamed T15199: Introduce PhabricatorEnv::getEnvConfigStr() - that always return a string from Introduce PhabricatorEnv::getEnvConfigString() - that always return a string to Introduce PhabricatorEnv::getEnvConfigStr() - that always return a string.
Mar 26 2023, 14:13 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan updated the task description for T15199: Introduce PhabricatorEnv::getEnvConfigStr() - that always return a string.
Mar 26 2023, 14:07 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan triaged T15200: PHP 8.2: Use of "parent" in callables is deprecated as Normal priority.
Mar 26 2023, 13:53 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan updated the task description for T15199: Introduce PhabricatorEnv::getEnvConfigStr() - that always return a string.
Mar 26 2023, 13:48 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan updated the task description for T15199: Introduce PhabricatorEnv::getEnvConfigStr() - that always return a string.
Mar 26 2023, 13:27 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan updated the task description for T15199: Introduce PhabricatorEnv::getEnvConfigStr() - that always return a string.
Mar 26 2023, 13:20 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan triaged T15199: Introduce PhabricatorEnv::getEnvConfigStr() - that always return a string as High priority.
Mar 26 2023, 13:16 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan updated the task description for T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies.
Mar 26 2023, 13:16 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan updated the task description for T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies.
Mar 26 2023, 12:56 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan added a subtask for T15198: PHP 8.2 deprecations fix strategies: T15145: Evaluate PHP Rector to quick refactor Phorge to support PHP 8.1 / 8.2 or do other things.
Mar 26 2023, 12:31 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan added a parent task for T15145: Evaluate PHP Rector to quick refactor Phorge to support PHP 8.1 / 8.2 or do other things: T15198: PHP 8.2 deprecations fix strategies.
Mar 26 2023, 12:31 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan added a subtask for T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo): T15198: PHP 8.2 deprecations fix strategies.
Mar 26 2023, 12:31 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan added a parent task for T15198: PHP 8.2 deprecations fix strategies: T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo).
Mar 26 2023, 12:31 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan removed a parent task for T15145: Evaluate PHP Rector to quick refactor Phorge to support PHP 8.1 / 8.2 or do other things: T15064: Make Phorge compatible with PHP 8.1/8.2/8.3.
Mar 26 2023, 12:30 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan added a parent task for T15198: PHP 8.2 deprecations fix strategies: T15064: Make Phorge compatible with PHP 8.1/8.2/8.3.
Mar 26 2023, 12:30 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan edited subtasks for T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, added: T15198: PHP 8.2 deprecations fix strategies; removed: T15145: Evaluate PHP Rector to quick refactor Phorge to support PHP 8.1 / 8.2 or do other things.
Mar 26 2023, 12:30 · PHP 8 support
valerio.bozzolan added a parent task for T15188: arc lint: "Function utf8_decode() is deprecated" in PHP 8.2: T15198: PHP 8.2 deprecations fix strategies.
Mar 26 2023, 12:30 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan added a subtask for T15198: PHP 8.2 deprecations fix strategies: T15188: arc lint: "Function utf8_decode() is deprecated" in PHP 8.2.
Mar 26 2023, 12:30 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan added a subtask for T15198: PHP 8.2 deprecations fix strategies: T15196: PHP 8.2: using ${var} in strings is deprecated.
Mar 26 2023, 12:29 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan added a parent task for T15196: PHP 8.2: using ${var} in strings is deprecated: T15198: PHP 8.2 deprecations fix strategies.
Mar 26 2023, 12:29 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan renamed T15196: PHP 8.2: using ${var} in strings is deprecated from Using ${var} in strings is deprecated, use {$var} instead to PHP 8.2: using ${var} in strings is deprecated.
Mar 26 2023, 12:29 · PHP 8 support, User-valerio.bozzolan
valerio.bozzolan added a subtask for T15198: PHP 8.2 deprecations fix strategies: T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies.
Mar 26 2023, 12:28 · PHP 8 support, User-valerio.bozzolan