- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Mar 27 2023
checkout master and cherry-pick from D25100
Mar 26 2023
I think that, from the view model, we should be able to call something like this:
Thanks @avivey honestly it was interesting and deeply connected to a scary PHP internal travel: if I understand correctly, "id" is considered a constant and expanded as the "id" string for backward compatibility reasons. Then, ${} expands that.
Wow. Probably there was only one case. Let's stay ready to reopen, but probably we are OK.
I added that sub-task since it is a bit hypocritical for us to ask why many people don't use Arcanist... if Arcanist does not support any official stable version of PHP.
It seems Rector.php has not an automatic rule for that.
simplify even more
try to make the diff even more simple
I renamed the proposal from configString() to configStr() so that I do not break the 80 characters lint limitation ihih
In D25031#1902, @Ekubischta wrote:This revision is nearly impossible to test
See my comments here D25030#1893
Error suppression with "@" is a poor solution to this issue
use PHP 7.4 to make lint happy