Page MenuHomePhorge
Feed Advanced Search

Mar 10 2023

valerio.bozzolan added a comment to T15101: Assigned to - Required Field.

One thing that could be done right now is:

Mar 10 2023, 07:39 · Maniphest
valerio.bozzolan closed T15109: Subpress listing of Projects in subscriber search as Wontfix.

Thank you again for your question. Sorry if I start marking this as closed since currently this specific Task with this title is probably not implementable as-is. We have some approaches, but without much feedback from the original poster and from other users it's very difficult to do something concrete that do not impact other workflows.

Mar 10 2023, 07:30 · Config, Projects, Maniphest
valerio.bozzolan renamed T15164: Resolving without Claiming causes error "Action with no effect" from Prevent warning "Action with no effect" when Resolving without Claiming to Resolving without Claiming causes error "Action with no effect".
Mar 10 2023, 06:33 · Maniphest, User-valerio.bozzolan
valerio.bozzolan updated the task description for T15164: Resolving without Claiming causes error "Action with no effect".
Mar 10 2023, 06:14 · Maniphest, User-valerio.bozzolan
valerio.bozzolan updated the task description for T15164: Resolving without Claiming causes error "Action with no effect".
Mar 10 2023, 05:58 · Maniphest, User-valerio.bozzolan

Mar 9 2023

valerio.bozzolan triaged T15164: Resolving without Claiming causes error "Action with no effect" as Wishlist priority.
Mar 9 2023, 17:52 · Maniphest, User-valerio.bozzolan
valerio.bozzolan created T15164: Resolving without Claiming causes error "Action with no effect".
Mar 9 2023, 17:52 · Maniphest, User-valerio.bozzolan
valerio.bozzolan added a comment to T15163: The Task Cover Image is visible only to the uploader (invisible to Task participants).

As a proof of concept I've uploaded a GIMP image (GIMP = green is my pepper) as Task image.

Mar 9 2023, 17:33 · Affects-Wikimedia, Maniphest, User-valerio.bozzolan, Cover Image, Workboard
valerio.bozzolan added a cover image to T15163: The Task Cover Image is visible only to the uploader (invisible to Task participants).
Mar 9 2023, 17:33 · Affects-Wikimedia, Maniphest, User-valerio.bozzolan, Cover Image, Workboard
valerio.bozzolan triaged T15163: The Task Cover Image is visible only to the uploader (invisible to Task participants) as Wishlist priority.
Mar 9 2023, 17:27 · Affects-Wikimedia, Maniphest, User-valerio.bozzolan, Cover Image, Workboard

Mar 8 2023

valerio.bozzolan updated the task description for T15159: The Feed should not display the content of deleted Task comments.
Mar 8 2023, 11:42 · Maniphest
valerio.bozzolan closed T15159: The Feed should not display the content of deleted Task comments as Invalid.

OK no sorry, it already does not show any content.

Mar 8 2023, 11:25 · Maniphest
valerio.bozzolan created T15159: The Feed should not display the content of deleted Task comments.
Mar 8 2023, 11:22 · Maniphest

Mar 4 2023

valerio.bozzolan edited Description on Maniphest (archived).
Mar 4 2023, 14:30

Feb 21 2023

valerio.bozzolan added a comment to T15109: Subpress listing of Projects in subscriber search.

@rraval Could you or someone else verify that a project that is made visible only to Administrators still shows up when a user opens the search selection list on the Subscribers field? And is this considered to be a bug or a feature? Of course i can set up a new Task for this if that makes sense.

Feb 21 2023, 06:43 · Config, Projects, Maniphest

Feb 8 2023

Higgs asked Q34: Configure display of search results (for tasks).
Feb 8 2023, 07:44 · Maniphest

Feb 3 2023

avivey added a revision to T15140: switch from PHPExcel to PHPSpreadsheet for Maniphest task export: D25054: Replace PHPExcel with PhpSpreadsheet.
Feb 3 2023, 07:42 · Maniphest
avivey created T15140: switch from PHPExcel to PHPSpreadsheet for Maniphest task export.
Feb 3 2023, 07:41 · Maniphest

Jan 25 2023

avivey added a comment to T15062: Introducing Phixator 2.

The concept we're aiming for is "Extension Store" - Core to be minimal,. and everything else to be an optional install, with an "app store" somewhere here, and making installing extensions easy.

Jan 25 2023, 19:03 · Phactory: Community Projects
arcadien added a comment to T15062: Introducing Phixator 2.

Isn't it possible to open a branch for that? who decide what feature can be integrated in Phorge? Just a remark, Phrequent *is* the application for time tracking, even quite empty by now

Jan 25 2023, 11:05 · Phactory: Community Projects

Jan 11 2023

Ekubischta added a comment to T15034: Show confirmation dialog when closing a modal if form contents have been changed.

D25015 was by @dcog If it can't be fixed with an update, this should be reverted

Jan 11 2023, 00:15 · Maniphest, UX

Jan 2 2023

bekay added a comment to T15034: Show confirmation dialog when closing a modal if form contents have been changed.

Hit esc today - Lost lots of typing

Just an upvote for landing D25015

Jan 2 2023, 10:52 · Maniphest, UX
bekay added inline comments to D25015: Show confirmation dialog when closing a modal if form contents have been changed.
Jan 2 2023, 10:48 · Maniphest (archived)

Nov 15 2022

arcadien added a comment to T15062: Introducing Phixator 2.

Looks great. I implemented a rough and simple logging feature over Phrequent, your extension looks more precise. I would think its better to merge/replace Phrequent rather than adding more implementations, though

Nov 15 2022, 09:50 · Phactory: Community Projects

Oct 21 2022

Cigaryno created T15131: Add Workboards support for Differential.
Oct 21 2022, 16:01 · Clarification Needed, Differential, Workboard, User-Cigaryno

Oct 15 2022

Cigaryno added a member for Maniphest (archived): Cigaryno.
Oct 15 2022, 08:02

Sep 21 2022

Matthew closed D25015: Show confirmation dialog when closing a modal if form contents have been changed.
Sep 21 2022, 17:26 · Maniphest (archived)

Sep 7 2022

20after4 added a comment to T15101: Assigned to - Required Field.

https://secure.phabricator.com/book/phabricator/article/custom_fields/ custom fields allow you to set the required property in configuration. I'm not sure if you can use this to override a default built-in field but you could possibly replace the built in field with a custom field with same/similar name and type: users.

Sep 7 2022, 16:45 · Maniphest

Aug 27 2022

Higgs updated subscribers of T15109: Subpress listing of Projects in subscriber search.

@avivey Thanks a lot for the hints. I will take a look at the Spaces. That sounds like it could be helpful for our purposes.
@rraval Could you or someone else verify that a project that is made visible only to Administrators still shows up when a user opens the search selection list on the Subscribers field? And is this considered to be a bug or a feature? Of course i can set up a new Task for this if that makes sense.

Aug 27 2022, 17:39 · Config, Projects, Maniphest

Aug 25 2022

avivey added a comment to T15109: Subpress listing of Projects in subscriber search.

(Regarding the original task description:)

Aug 25 2022, 17:39 · Config, Projects, Maniphest
rraval added a comment to T15109: Subpress listing of Projects in subscriber search.

But still it is worrisome that we can configure visibility only by Administrators, yet everybody can assign the project as subscriber... Maybe that is a bug ?

Aug 25 2022, 13:13 · Config, Projects, Maniphest
Higgs added a comment to T15109: Subpress listing of Projects in subscriber search.

@rraval Right, i overlooked this setting. I managed to hide most projects from the Subscribers Search panel. We also have reduced the number of Projects to keep things more tidy.

Aug 25 2022, 13:04 · Config, Projects, Maniphest

Aug 24 2022

rraval added a comment to T15109: Subpress listing of Projects in subscriber search.

@Higgs You should be able to ProjectEdit DetailsVisible ToProject Members. Does that do what you expect?

Aug 24 2022, 14:03 · Config, Projects, Maniphest
Higgs added a comment to T15109: Subpress listing of Projects in subscriber search.

We use Projects for grouping users into teams. But unfortunately every user can see all Projects and assign them as subscribers to Tasks, regardless if they are members or not. Normally (in our case) Tasks are only relevant for users in the same project. Having the other projects displayed in the subscribers selection is unfortunate in this case.

Aug 24 2022, 08:37 · Config, Projects, Maniphest

Aug 23 2022

rraval added a comment to T15109: Subpress listing of Projects in subscriber search.

Our instance uses a ton of projects as "groups of people that need to be notified", so we use project subscribers a lot.

Aug 23 2022, 19:38 · Config, Projects, Maniphest
Higgs created T15109: Subpress listing of Projects in subscriber search.
Aug 23 2022, 10:55 · Config, Projects, Maniphest

Jul 26 2022

avivey added a comment to T15101: Assigned to - Required Field.

I don't think we have this capability right now.

Jul 26 2022, 15:18 · Maniphest

Jul 1 2022

Matthew lowered the priority of T15101: Assigned to - Required Field from Unbreak Now! to Needs Triage.

Please do not triage tasks yourself, we will integrate it into the roadmap as we go.

Jul 1 2022, 16:17 · Maniphest
SmoothPlay triaged T15101: Assigned to - Required Field as Unbreak Now! priority.
Jul 1 2022, 07:31 · Maniphest
SmoothPlay created T15101: Assigned to - Required Field.
Jul 1 2022, 07:31 · Maniphest

Jun 14 2022

Ekubischta added a comment to T15034: Show confirmation dialog when closing a modal if form contents have been changed.

Hit esc today - Lost lots of typing

Jun 14 2022, 16:11 · Maniphest, UX

May 18 2022

dtf added a member for Maniphest (archived): dtf.
May 18 2022, 18:54

Dec 1 2021

speck added a comment to T15062: Introducing Phixator 2.

Time tracking is an interesting topic. At my company we addressed this by having a Herald WebHook hit our internal server whenever activity we're interested in tracking happens. Our internal server tracks these activities from multiple sources (not just Phab/Phorge) and users can go in to see all their activity linked up and input the approximate time spent on those activities.

Dec 1 2021, 16:55 · Phactory: Community Projects

Nov 25 2021

Labricator added a comment to T15062: Introducing Phixator 2.

I'd definitely love to see this later. I MIGHT be able to get to this later.

Nov 25 2021, 17:41 · Phactory: Community Projects

Nov 23 2021

Ekubischta added a comment to T15062: Introducing Phixator 2.

This looks pretty great! - I think T15030 is the general covering task for Extensions

Nov 23 2021, 20:06 · Phactory: Community Projects

Nov 22 2021

motla updated subscribers of T15062: Introducing Phixator 2.
Nov 22 2021, 15:15 · Phactory: Community Projects
motla created T15062: Introducing Phixator 2.
Nov 22 2021, 15:15 · Phactory: Community Projects

Oct 13 2021

speck accepted D25015: Show confirmation dialog when closing a modal if form contents have been changed.

Thanks!

Oct 13 2021, 21:08 · Maniphest (archived)
Ekubischta accepted D25015: Show confirmation dialog when closing a modal if form contents have been changed.
Oct 13 2021, 20:53 · Maniphest (archived)
Ekubischta added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.
In D25015#826, @speck wrote:

I think that makes sense. Could you make a task to address this so we don’t lose track of it? Then let’s get this landed.

Oct 13 2021, 20:52 · Maniphest (archived)
speck added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

I think that makes sense. Could you make a task to address this so we don’t lose track of it? Then let’s get this landed.

Oct 13 2021, 16:35 · Maniphest (archived)
Ekubischta added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

I feel like we should move translation to a new revision, so we can move forward with this one.

Oct 13 2021, 01:47 · Maniphest (archived)

Oct 5 2021

dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

I'm down to do a https://meet.jit.si/ with someone else who is also down for this idea as well as the idea of translatable generic confirm() and alert() dialogs that can trivially go from pht() in PHP to JavaScript. Anyone?

Oct 5 2021, 03:43 · Maniphest (archived)
dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

We can have a i18n option for both confirmDialog and alertDialog.... Let's do this, who is down?

Oct 5 2021, 03:38 · Maniphest (archived)
dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.
In D25015#793, @dcog wrote:
In D25015#792, @dcog wrote:

Thanks -- Can anyone think of a more generic solution here as far as dialogs? Something for both confirm() and prompt().

One thing to note here: Native JavaScript blocks execution when these functions are used. This is apparently nearly impossible behavior to mimic exactly, but we can solve this with asynchronous functions with our generic and platform-specific confirm() and alert() functions. Otherwise, should there be an always-available global translation for both alert() and confirm()?

Example of custom confirm():

JX.confirm({
  message: "Form data may have changed. Are you sure you want to close this dialog?",
  buttonConfirm: "Discard Changes",
  buttonCancel: "Cancel",
  onConfirm: function() {
    // Something something
  }
});

But it would need translation added...

Oct 5 2021, 03:37 · Maniphest (archived)
dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.
In D25015#792, @dcog wrote:

Thanks -- Can anyone think of a more generic solution here as far as dialogs? Something for both confirm() and prompt().

One thing to note here: Native JavaScript blocks execution when these functions are used. This is apparently nearly impossible behavior to mimic exactly, but we can solve this with asynchronous functions with our generic and platform-specific confirm() and alert() functions. Otherwise, should there be an always-available global translation for both alert() and confirm()?

Oct 5 2021, 03:36 · Maniphest (archived)
dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

Thanks -- Can anyone think of a more generic solution here as far as dialogs? Something for both confirm() and prompt().

Oct 5 2021, 03:35 · Maniphest (archived)

Sep 22 2021

speck added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.
In D25015#735, @avivey wrote:

I may be late for the party, but can't the translated verbiage be provided to the dialog in the $form_attributes in AphrontDialogView.php:337, and read using form.getAttribute(key) in the js?

I looked at the $form_attributes a week or so back but I think those end up being transformed into the literal HTML attributes of the dialog's <form> element. I think we need to add a new field to the dialog, something like setMetadata() that @dcog found in the workboard view.

Sep 22 2021, 01:16 · Maniphest (archived)

Sep 20 2021

avivey added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

I may be late for the party, but can't the translated verbiage be provided to the dialog in the $form_attributes in AphrontDialogView.php:337, and read using form.getAttribute(key) in the js?

Sep 20 2021, 15:04 · Maniphest (archived)

Sep 17 2021

dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

What if, to get this functionality pushed through, we for now change the verbiage to two English words -- "Discard changes?"

Sep 17 2021, 02:17 · Maniphest (archived)

Sep 13 2021

dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

Dug up some more info as well...

Sep 13 2021, 20:29 · Maniphest (archived)
speck updated subscribers of D25015: Show confirmation dialog when closing a modal if form contents have been changed.

@Leon95 updated/included some translated text for calendar widgets under D25016 which may also be useful as reference. However one big difference is that the calendar widget has its own explicit view/behavior, whereas front-end workflows have multiple varying uses with different content.

Sep 13 2021, 00:12 · Maniphest (archived)

Sep 4 2021

dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.
In D25015#678, @speck wrote:

It looks like there is a JX.phtize() which appears to be used to create a function that mimics pht() in JavaScript but I believe requires that whatever is passed to phtize() is effectively a map of translations which is presumably passed from the server somewhere. I've not yet uncovered this later part.

Sep 4 2021, 22:28 · Maniphest (archived)
speck added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

It looks like there is a JX.phtize() which appears to be used to create a function that mimics pht() in JavaScript but I believe requires that whatever is passed to phtize() is effectively a map of translations which is presumably passed from the server somewhere. I've not yet uncovered this later part.

Sep 4 2021, 19:10 · Maniphest (archived)

Aug 24 2021

speck added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.
In D25015#633, @avivey wrote:

In this case I think the error text is agnostic of the instance of the dialog.

I was thinking about this use-case, which implies to me that the dialog author should be involved in the error text:

image.png (206×423 px, 14 KB)

Aug 24 2021, 18:51 · Maniphest (archived)

Aug 20 2021

avivey added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

What are the implications of making changes to the javelinjs.com https://github.com/phacility/javelin/ library?

Aug 20 2021, 06:58 · Maniphest (archived)

Aug 19 2021

dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

Also I don’t believe javelin.io is related to the Javalin used in Phab.

Aug 19 2021, 05:45 · Maniphest (archived)
speck added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

Ah I did not look closely enough. Dang. We should be attaching the message to the view on the server then, somehow.

Aug 19 2021, 04:51 · Maniphest (archived)
dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

Oh, another potential concern...

Aug 19 2021, 04:34 · Maniphest (archived)
dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.
In D25015#616, @speck wrote:

In this case I think the error text is agnostic of the instance of the dialog. From looking at AphrontDialogView I didn't see any obvious way to include additional fields/text that could be pulled out here on the front end. Looking elsewhere in this file (line ~297) it looks like some other generic text is used

if (!this._paused) {
  JX.$E('Resuming a workflow which is not paused!');
}

However that's the only case where JX.$E is used outside of an is-development check. I'm not sure where these Javascript translations would go or when the translation file is generated.

Aug 19 2021, 04:33 · Maniphest (archived)
speck added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

In this case I think the error text is agnostic of the instance of the dialog. From looking at AphrontDialogView I didn't see any obvious way to include additional fields/text that could be pulled out here on the front end. Looking elsewhere in this file (line ~297) it looks like some other generic text is used

if (!this._paused) {
  JX.$E('Resuming a workflow which is not paused!');
}
Aug 19 2021, 01:34 · Maniphest (archived)

Aug 18 2021

20after4 added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

+1 this has bitten me before.

Aug 18 2021, 18:08 · Maniphest (archived)

Jul 28 2021

avivey added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

The translated text can be a property of the dialogue itself, if we're worried about having extra objects laying around - the confirmation feels like it's a feature of the dialogue anyway.

Jul 28 2021, 07:20 · Maniphest (archived)
avivey added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

There's no way to invoke pht from JS (because it's really complicated in the general case). The general practice is to provide the translated value from PHP when building the relevant objects. There should be an example in the UIExamples app - there's a page with buttons built in JS.

Jul 28 2021, 07:11 · Maniphest (archived)
dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

I 100% agree with this. Is there no way to invoke internationalization via JS only? If not, that's perfectly great, but wondering about an answer offhand.

Jul 28 2021, 06:40 · Maniphest (archived)

Jul 26 2021

Ekubischta added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.
Jul 26 2021, 22:31 · Maniphest (archived)

Jul 25 2021

dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

On a related note, tonight I discovered this UIExamples application (changing links from my Vagrant install):

Jul 25 2021, 04:07 · Maniphest (archived)
dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.
In D25015#532, @speck wrote:

It’s generally more clear to have the buttons read “Discard changes” vs. “Ok” or “Yes”

I agree

Would it be easy to change the prompt to be more descriptive with actions?

For me, I think it might be on the hard side... and maybe add some bloat? Unless there is a styled generic confirm box created that maybe uses a callback instead of blocks execution...

Jul 25 2021, 03:30 · Maniphest (archived)
dcog updated the summary of D25015: Show confirmation dialog when closing a modal if form contents have been changed.
Jul 25 2021, 03:02 · Maniphest (archived)

Jul 24 2021

speck added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

Would it be easy to change the prompt to be more descriptive with actions? It’s generally more clear to have the buttons read “Discard changes” vs. “Ok” or “Yes”

Jul 24 2021, 21:04 · Maniphest (archived)
dcog requested review of D25015: Show confirmation dialog when closing a modal if form contents have been changed.
Jul 24 2021, 06:55 · Maniphest (archived)
dcog updated the task description for T15034: Show confirmation dialog when closing a modal if form contents have been changed.
Jul 24 2021, 06:47 · Maniphest, UX
dcog created T15034: Show confirmation dialog when closing a modal if form contents have been changed.
Jul 24 2021, 06:47 · Maniphest, UX

Jun 15 2021

Matthew changed the visibility for Maniphest (archived).
Jun 15 2021, 04:26

Jun 11 2021

Matthew created Maniphest (archived).
Jun 11 2021, 16:16