remove unuseful newline

Oh wow, that is a really unexpected way to create tags.

We have a public project tag used by a team. Some tasks associated with that public project tag are public tasks visible to everyone and anyone, so they are not in an access-restricted Space but default S1. Some tasks associated with that public project tag are temporarily non-public, "secret" tasks that should only be visible to that team and nobody else, so they are in an access-restricted Space that can only be accessed by team members.

In my installation this would not be a reasonable expectation. We have a public project tag used by a team. Some tasks associated with that public project tag are public tasks visible to everyone and anyone, so they are not in an access-restricted Space but default S1. Some tasks associated with that public project tag are temporarily non-public, "secret" tasks that should only be visible to that team and nobody else, so they are in an access-restricted Space that can only be accessed by team members.
So I'd rather envision a Herald rule: for a Maniphest task, if is newly created is true && Space is Sxx, then add project tag #whatever. (The other way round is not particularly feasible: The task would have a default view setting for a moment and potentially visible to outsiders, before moving it to a view-restricted Space).

I was confused about why I couldn't tag a task with any random tag that I wanted to create on the fly as I'd do in Meta's Phabricator. It took me some time to realize that tags mean projects.

To clarify: currently existing auto-tagging is not about the column from which the task is created. It's about tagging with the project to which the column belongs.

It's not "impossible" on the technical level, it's just not obviously the right solution.

But also, why is it impossible? When a task is created from a column, it automatically pre-populates the tag column with the project it is created from. It seems trivial to implement a patch that would auto-detect the project's space and set it accordingly for the task.

Then, if every project could choose its own Task Create/Edit Form Configuration, it would solve the issue. Maybe form configurations could be tagged with projects, and when no tag = show for all projects?

I'd assume that it also links the task and the diff together and optionally allows to close the task automatically on diff land?

Just adding references

...set it by default to the space that the project belongs to...

Thanks, that's useful to know!

In T15903#18780, @pppery wrote:

Ideally strings not shown to the user would also not be wrapped in pht(...) at all to avoid wasting translator's time.

Remove unneeded if statements.

In D25764#20704, @valerio.bozzolan wrote:

Thanks. Have you already tried with just CSS? Any issue in that?

Ideally strings not shown to the user would also not be wrapped in pht(...) at all to avoid wasting translator's time. This is contrary to the documentation inherited from old upstream at https://we.phorge.it/book/contrib/article/internationalization/, though,

Remove typo

This is an issue in https://we.phorge.it/source/phorge/browse/master/src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php . In getObjectEmbedPattern(), preg_quote($prefix) returns \# and the method finally returns (\B{\#([^.\s?!,:;{}#\(\)"'\*/~]+(?:[^\s?!,:;{}#\(\)"'\*/~]*[^.\s?!,:;{}#\(\)"'\*/~]+)*)([,\s](?:[^}\\]|\\.)*)?}\B)u.
Within apply($text), $text becomes null after that first preg_replace_callback, so the second call barks.

I did some digging:

Create $page_size var to avoid casting twice

This entire method looks very hacky to me. I guess at the bottom of every useful UI, there's a bunch of if statements that map icon names to code.

Thanks. Have you already tried with just CSS? Any issue in that? Maybe something like this:

BTW - is something normalizing the header casing?

BTW - is something normalizing the header casing?