lol whatever, but please consider this instead to make happy also future/better versions of PHPStan

Giving this:

Double-slam-accept

I'm not skilled enough to look into the bigger picture, however maybe the Edit Column dialog could have a third field apart from Name and Point Limit to also have Task Limit (or Card Limit?). Point Limit and Task Limit then must be mutually exclusive (do not allow to set both for a column, or even...board?), somehow.

Double-accept asd

Borrow a short sentence from Valerio as his English skills in the morning are much much better than mine

Yep. In all cases it's at least a full-table-scan on file_attachment. Probably a bit more RAM-efficient with the NOT EXISTS thing since it does not need to have all file PHIDs in memory.

The title cannot exceed %d characters :D

Thanks. Also please show to the end user the same number, using some semantic pirouettes. So this limit is easier to be found.

Thanks. Also please show to the end user the same number, using some semantic pirouettes. So this limit is easier to be found.

In D25737#20607, @avivey wrote:

I'm happy to log it, but I'm nos sure this counts as "fixes" the issue - it still requires an admin to monitor the logs.
But then maybe T15887 and its friends can be collected to a single common "more visibility for Herald errors" issue.

Move max task title length into a variable

Seems super-reasonable. Please save that 255 in a variable and re-use in pht("Bla bla %d bla", $title_max_length) or similar, so it's easier to customize without invalidating translations

Tested, makes sense, lovely feature, no possible NULL pointers since isCommentTransaction() calls hasComment() that eliminates the possibility of getComment() being NULL; no possibility to get exception "Comment for this transaction was not loaded" since that was already checked with just isCommentTransaction(); green light 🌈

Little premise, in this method the return statement is dead, unreachable code:

In T15750#18669, @CryingWolf wrote:

Is this feature meant to include displaying custom project fields in search results as well? (and possibly for other applications that allow custom field definitions)

I'm happy to log it, but I'm nos sure this counts as "fixes" the issue - it still requires an admin to monitor the logs.
But then maybe T15887 and its friends can be collected to a single common "more visibility for Herald errors" issue.

Make the PHPDoc and the method name shamelessly admit its real intentions to the whole world out there

Correct off-by-one error :P

I like ping-pong :D

What Valerio says: Only render OGP tags for anonymous access to public objects; refactor

Is this feature meant to include displaying custom project fields in search results as well? (and possibly for other applications that allow custom field definitions)

Thaaaaaaanks 🦄

arc lint no check CSS syntax? Meh

Do whatever Valerio says!

Replace file icon with copy path button in file header bars

What about replacing that legacy "unuseful" file icon on the left, with your new copy-button?

This seems ready. Just the proposed inline things if you like to. Thanks.

Tested again. This feature is beautiful. Thanks again. Let's increase the Wealth token.

I do not understand this thing more than this. Help welcome.

OH GOSH YES

Tested again. Double-accept.

• Split getting values and rendering meta tags into separate private methods
• Fix description length check

Triple-slam-accept

• Fix the $award_phids thingy to do the $award_phids[$phid] thing
• I prefer to keep if (!$errors) as that part of code is supposed to check for (any) errors

Before and after it throws an exception; after it involves the return command to do so.

follow @valerio.bozzolan what suggested at https://we.phorge.it/D25750#20386.
we barely used pattern search but it indeed was broken.
with this fix, it works.

We can take inspiration from Phame (?)

It's perfect as-is. Just adding last notes since I'm in verbose mode

I thought there was a ->setFormErrors($errors) but it's not the case. Nice as-is. Tested thanks :3

Uhm. Before the change, the method returns void. After the change, the method returns void. So this proposed change would be "to make PHPStan happy" but I expect it will highlight in future versions of PHPStan as well.

Double-slam-accept

Use canResolve() as found by Valerio (so much for my reading skills)

git rebase master (just because we can)

Seems good thanks. It seems we can also have it shorter with canResolve() 🤔

You didn't have Trusted Contributors membership, which provides access to the repo. Try now

In D25750#20406, @aklapper wrote:

Could you try arc land instead of git push?