Page MenuHomePhorge
Differential D25074

FileUpload: show File page instead of binary file
ClosedPublic
Actions

Authored by valerio.bozzolan on Mar 12 2023, 21:08.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 10, 18:31
Unknown Object (File)
Sun, Apr 7, 09:56
Unknown Object (File)
Sat, Apr 6, 19:56
Unknown Object (File)
Fri, Apr 5, 20:28
Unknown Object (File)
Mon, Apr 1, 22:55
Unknown Object (File)
Mon, Apr 1, 13:42
Unknown Object (File)
Mon, Apr 1, 00:54
Unknown Object (File)
Mon, Apr 1, 00:54
View All Files
Subscribers
avivey
Cigaryno
Matthew
speck
tobiaswiese

Details

Reviewers
avivey
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15165: Drag & Drop: popup link should be a File page (not its hotlink)
Commits
rP4f356838beda: FileUpload: show File page instead of binary file
Summary

This modification improves a single link shown to the user.

The goal is to make it easier to change file permissions or
file name or whatever just after the upload of the file itself.

Before this change, doing that was difficult because clicking
on the popup would send you back to the binary file only.

Closes T15165

Test Plan
  • upload a file using drag & drop (for example in a comment)
  • click on the popup's link
  • you see the File page, not the binary file

Diff Detail

Repository
rP Phorge
Branch
T15165-popup-link-to-file-page
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 130
Build 130: arc lint + arc unit

Event Timeline

valerio.bozzolan created this revision.Mar 12 2023, 21:08
Owners added a reviewer: O1: Blessed Committers.Mar 12 2023, 21:08
Herald added subscribers: Cigaryno, Matthew, tobiaswiese, speck. · View Herald TranscriptMar 12 2023, 21:08
valerio.bozzolan requested review of this revision.Mar 12 2023, 21:08
Harbormaster completed remote builds in B130: Diff 337.Mar 12 2023, 21:08
valerio.bozzolan edited the test plan for this revision. (Show Details)Mar 12 2023, 21:09
valerio.bozzolan mentioned this in Z1: Phorge.Mar 16 2023, 14:21
avivey subscribed.Mar 16 2023, 19:18
avivey added inline comments.
webroot/rsrc/js/core/FileUpload.js
41

I think we call these "monograms".

valerio.bozzolan updated this revision to Diff 346.Mar 17 2023, 08:05

rename getPageID() to getMonogram() and add few inline comments

Harbormaster completed remote builds in B137: Diff 346.Mar 17 2023, 08:05
avivey accepted this revision.Mar 17 2023, 08:06
This revision is now accepted and ready to land.Mar 17 2023, 08:06
valerio.bozzolan marked an inline comment as done.Mar 17 2023, 08:06
Closed by commit rP4f356838beda: FileUpload: show File page instead of binary file. · Explain WhyMar 17 2023, 08:07
This revision was automatically updated to reflect the committed changes.
valerio.bozzolan added a commit: rP4f356838beda: FileUpload: show File page instead of binary file.
valerio.bozzolan mentioned this in 2023 Week 2.Mar 17 2023, 08:10
avivey mentioned this in 2023 Week 17.Apr 25 2023, 06:54
valerio.bozzolan mentioned this in Wikimania Hackathon 2023 Singapore.Aug 19 2023, 04:47
valerio.bozzolan mentioned this in Wikimania Hackathon 2023 Singapore.Aug 28 2023, 16:39

Revision Contents
Changeset List

PathSizePackages
webroot/
rsrc/
js/
core/
10 linesO1: Blessed Committers

Diff 337

View Options

webroot/rsrc/js/core/FileUpload.js

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0