Paths

Table of Contentst

Differential D25060

Fix NULL pointer exception in some circumstances from Calendar's homepage
ClosedPublic
Actions

Authored by valerio.bozzolan on Nov 28 2022, 15:02.

Details

Reviewers

20after4

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15136: Fix NULL pointer exception from Calendar's homepage in some circumstances

Commits

rPdc558b5538cd: Fix NULL pointer exception in some circumstances from Calendar's homepage

Summary

After importing specific weird events, for example from Google Calendar (bleah), it can happen that the Calendar's homepage becomes broken.

This was the Exception error shown to video:

"Call to a member function getEventsBetween() on null"

It was happening since this method can return NULL:

PhabricatorCalendarEventQuery#newRecurrenceSet()

This changeset verifies this condition from the Calendar's homepage.

Closes T15136

Test Plan

I tried in my server. I've executed the syntax lint. On my local machine I was not able to run "arc diff" since it tries to connect to root@localhost for some reasons.

Diff Detail

Repository

rP Phorge

Branch

D25060 (branched from master)

Lint

Lint Passed

Unit

Tests Skipped

Build Status

Buildable 99
Build 99: arc lint + arc unit

Event Timeline

valerio.bozzolan created this revision.Nov 28 2022, 15:02

Owners added a reviewer: O1: Blessed Committers.Nov 28 2022, 15:02

Herald added subscribers: Matthew, tobiaswiese, speck. · View Herald TranscriptNov 28 2022, 15:02

valerio.bozzolan requested review of this revision.Nov 28 2022, 15:02

valerio.bozzolan added inline comments.Nov 28 2022, 16:27

src/applications/calendar/query/PhabricatorCalendarEventQuery.php
234	Basically I've just indented the `$recurrences = $set->getEventsBetween()` under an `if($set)`.

valerio.bozzolan retitled this revision from Fix NULL pointer exception from Calendar's homepage to Fix NULL pointer exception in some circumstances from Calendar's homepage.Nov 28 2022, 20:25

valerio.bozzolan edited the summary of this revision. (Show Details)

valerio.bozzolan added a project: Calendar.

valerio.bozzolan added a task: T15136: Fix NULL pointer exception from Calendar's homepage in some circumstances.

run lint

Harbormaster completed remote builds in B99: Diff 295.Nov 28 2022, 21:14

This looks good to me. It seems like I may have actually ran into this before and just didn't manage to upstream the fix from Wikimedia's fork.

20after4 accepted this revision.Nov 30 2022, 18:13

This revision is now accepted and ready to land.Nov 30 2022, 18:13

$ arc land

Exception: You do not have permission to push to this repository.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Cigaryno subscribed.Dec 1 2022, 18:50

I also tried executing yes | arc land but nothing.

I also tried the GNU version of yes that huge efficiency - https://codegolf.stackexchange.com/a/199534 but nothing.

I also tried to re-implement yes using a low-level approach, but nothing:

yesyes

As workaround it seems I need to become a Blessed Committers until I find a definitive solution to land.

0 subscribed.Dec 3 2022, 00:29

0 added inline comments.

src/applications/calendar/query/PhabricatorCalendarEventQuery.php
228	The rest of the codebase uses `array()` instead of `[]`, but that might just be for compatibility with old PHP.

add support for PHP versions that should be nuked

Harbormaster completed remote builds in B100: Diff 296.Dec 5 2022, 11:24

Hi @Matthew I think I cannot run arc land since I'm not in Blessed Committers

In D25060#1987, @valerio.bozzolan wrote:

Hi @Matthew I think I cannot run arc land since I'm not in Blessed Committers

That is correct, I am working on getting this landed. Please stop pinging me, it will land soon.

Closed by commit rPdc558b5538cd: Fix NULL pointer exception in some circumstances from Calendar's homepage. · Explain WhyDec 8 2022, 22:32

This revision was automatically updated to reflect the committed changes.

Matthew added a commit: rPdc558b5538cd: Fix NULL pointer exception in some circumstances from Calendar's homepage.

valerio.bozzolan mentioned this in 2023 Week 2.Mar 13 2023, 18:26

avivey mentioned this in 2023 Week 17.Apr 25 2023, 06:54

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

calendar/

query/

PhabricatorCalendarEventQuery.php

12 lines

O1: Blessed Committers

Diff 295

View Options

src/applications/calendar/query/PhabricatorCalendarEventQuery.php

Fix NULL pointer exception in some circumstances from Calendar's homepageClosedPublicActions