Page MenuHomePhorge

Update sprite sheets
ClosedPublic

Authored by MacFan4000 on Oct 4 2022, 14:39.
Referenced Files
F2055914: D25055.id.diff
Thu, Mar 28, 00:52
F2054645: D25055.diff
Wed, Mar 27, 18:44
Unknown Object (File)
Sun, Mar 24, 05:39
Unknown Object (File)
Wed, Mar 20, 09:52
Unknown Object (File)
Feb 25 2024, 07:33
Unknown Object (File)
Feb 25 2024, 06:53
Unknown Object (File)
Feb 25 2024, 06:48
Unknown Object (File)
Feb 13 2024, 18:09

Details

Summary

This fully updates some login provider icons. Somehow this didn't work fully on previous updates. I used --force this time.

Test Plan

None just ran the script which regenerated the spritesheets.

Diff Detail

Repository
rP Phorge
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 89
Build 89: arc lint + arc unit

Event Timeline

Cigaryno requested changes to this revision.Oct 6 2022, 19:00

Could you do this:

  • Replace the Phabricator logo with the Phorge logo.
  • Replace the G+ like Google logo with the current Google logo that was used since 2015.

Optional: Replace the Facebook logo with the new one that has a different blue.

This revision now requires changes to proceed.Oct 6 2022, 19:00

Could you do this:

  • Replace the Phabricator logo with the Phorge logo.
  • Replace the G+ like Google logo with the current Google logo that was used since 2015.

Optional: Replace the Facebook logo with the new one that has a different blue.

I am not intending to update actual individual icon files in this commit - only running the script to regenerate the spritesheets based on the individual image files. Actually changing images can be done in a different commit. Also Using outdated logos isn't a big deal. And hard to say if we really want to change the Phabricator logo, as that auth provider could still be used to connect to an old Phabricator instance.

MacFan4000 added a reviewer: Blessed Committers.
avivey subscribed.

We should connect this script (scripts/celerity/*.php) into bin/celerity.

This revision is now accepted and ready to land.Oct 28 2022, 15:35

Could somebody please land this at some point t?

This revision was automatically updated to reflect the committed changes.