Differential D25030 Diff 82 src/lint/ArcanistLintMessage.php

Changeset View

Standalone View

src/lint/ArcanistLintMessage.php

Context not available.
	$code = (string)$code;	$code = (string)$code;

	$maximum_bytes = 128;	$maximum_bytes = 128;
	$actual_bytes = strlen($code);	$actual_bytes = @strlen($code);

	if ($actual_bytes > $maximum_bytes) {	if ($actual_bytes > $maximum_bytes) {
	throw new Exception(	throw new Exception(
Context not available.

	public function setName($name) {	public function setName($name) {
	$maximum_bytes = 255;	$maximum_bytes = 255;
	$actual_bytes = strlen($name);	$actual_bytes = @strlen($name);

	if ($actual_bytes > $maximum_bytes) {	if ($actual_bytes > $maximum_bytes) {
	throw new Exception(	throw new Exception(
Context not available.
	}	}

	// Strings like "234" are fine, coerce them to integers.	// Strings like "234" are fine, coerce them to integers.
	if (is_string($value) && preg_match('/^\d+\z/', $value)) {	if (is_string($value) && @preg_match('/^\d+\z/', $value)) {
	$value = (int)$value;	$value = (int)$value;
	}	}

Context not available.
	$replacement = $this->getReplacementText();	$replacement = $this->getReplacementText();
	$original = $this->getOriginalText();	$original = $this->getOriginalText();

	$replacement_length = strlen($replacement);	$replacement_length = @strlen($replacement);
	$original_length = strlen($original);	$original_length = @strlen($original);

	$minimum_length = min($original_length, $replacement_length);	$minimum_length = min($original_length, $replacement_length);

Context not available.
	}	}

	if ($suffix_length) {	if ($suffix_length) {
	$original = substr($original, 0, -$suffix_length);	$original = @substr($original, 0, -$suffix_length);
	$replacement = substr($replacement, 0, -$suffix_length);	$replacement = @substr($replacement, 0, -$suffix_length);
	}	}

	$line = $this->getLine();	$line = $this->getLine();
	$char = $this->getChar();	$char = $this->getChar();

	if ($prefix_length) {	if ($prefix_length) {
	$prefix = substr($original, 0, $prefix_length);	$prefix = @substr($original, 0, $prefix_length);

	// NOTE: Prior to PHP7, `substr("a", 1)` returned false instead of	// NOTE: Prior to PHP7, `@substr("a", 1)` returned false instead of
	// the empty string. Cast these to force the PHP7-ish behavior we	// the empty string. Cast these to force the PHP7-ish behavior we
	// expect.	// expect.
	$original = (string)substr($original, $prefix_length);	$original = (string)@substr($original, $prefix_length);
	$replacement = (string)substr($replacement, $prefix_length);	$replacement = (string)@substr($replacement, $prefix_length);

	// If we've removed a prefix, we need to push the character and line	// If we've removed a prefix, we need to push the character and line
	// number for the warning forward to account for the characters we threw	// number for the warning forward to account for the characters we threw
Context not available.